Re: [PATCH 3/5] riscv: dts: spacemit: k3-com260: Add SPI NOR flash

[Sarah Emery <sarah.emery@canonical.com>]

Hi Troy,

 > +			uboot@210000 {
 > +				reg = <0x210000 0x5f0000>;
 > +			};

This partition ends at 0x800000. On the CoM260 with EDK2, 0x700000 to
0x7c0000 holds the variable store (NVRAM and FTW), so reflashing this
partition from Linux would erase it.

I think we could split it like this:

    uboot@210000 {
       reg = <0x210000 0x4f0000>;
    };

    var@700000 {
       reg = <0x700000 0xc0000>;
       read-only;
    };

What do you think?

The Pico-ITX node also uses 0x5f0000, but I think it should be modified 
to split out the var part too if it makes sense here.

The Pico-ITX flash node also has vcc-supply = <&aldo2>.
Shouldn't this be present here as well?

The rest of the patch LGTM and matches what we have already tested in 
the Ubuntu kernel.

Thanks,
Sarah