From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Brian Masney <bmasney@redhat.com>
Cc: Pengyu Luo <mitltlatltl@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, White Lewis <liu224806@gmail.com>,
Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH] clk: qcom: dispcc-sc8280xp: remove CLK_SET_RATE_PARENT from byte_div_clk_src dividers
Date: Tue, 30 Jun 2026 16:37:12 +0200 [thread overview]
Message-ID: <798d2516-0772-4f98-8fad-959a1daf71bc@oss.qualcomm.com> (raw)
In-Reply-To: <CABx5tqK3MymYQZ4owofnzFLnjt+96njw5RG2Vwxo7UJ93A-42g@mail.gmail.com>
On 3/23/26 5:07 PM, Brian Masney wrote:
> Hi Konrad,
>
> On Mon, Mar 23, 2026 at 8:48 AM Konrad Dybcio
> <konrad.dybcio@oss.qualcomm.com> wrote:
>> On 3/13/26 5:54 PM, Brian Masney wrote:
>>> On Fri, Mar 06, 2026 at 06:27:20PM -0500, Brian Masney wrote:
>>>> On Wed, Mar 4, 2026 at 10:08 AM Pengyu Luo <mitltlatltl@gmail.com> wrote:
>>>>> On Wed, Mar 4, 2026 at 10:50 PM Brian Masney <bmasney@redhat.com> wrote:
>>>>>> On Tue, Mar 03, 2026 at 01:10:43PM +0100, Konrad Dybcio wrote:
>>>>>>> On 3/3/26 12:55 PM, Pengyu Luo wrote:
>>
>> [...]
>>
>>> Ignore my previous patch set. In my v6 that I just posted, I updated
>>> clk-divider.c to support the new v2 clk negotiation logic. The
>>> clk_regmap_div_ops uses this driver, so you shouldn't have to make any
>>> code changes.
>>>
>>> Anyways, would someone from Qualcomm be willing to test this? The
>>> procedure is fairly simple:
>>
>> Unfortunately, I don't think it's easy to get your hands on a 8280
>> device with DSI.. maybe Pengyu could test that on his tablet/laptop.
>
> It doesn't have to be an 8280 SoC. It could be any device that has the
> issue where the parent rate change screws up that portion of the clock
> tree, and crashes the device. This has been a long-standing issue in
> the clk framework. I know you recently posted a series for 5 other
> SoCs with a similar change [1], so any of those other devices should
> work as well.
>
> [1] https://lore.kernel.org/linux-arm-msm/20260304-topic-dsi_byte_fixup-v1-0-b79b29f83176@oss.qualcomm.com/
>
> The kunit tests in my clk scaling patch set demonstrate the issues
> that I have worked on. For example, in my test scenario, I start with
> a parent, and two children. The parent can do any rate. The two
> children are simple dividers. This is the current behavior today:
>
> KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->parent_clk), 24 * HZ_PER_MHZ);
> KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->child1_clk), 24 * HZ_PER_MHZ);
> KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->child2_clk), 24 * HZ_PER_MHZ);
>
> ret = clk_set_rate(ctx->child1_clk, 32 * HZ_PER_MHZ);
>
> /*
> * The last sibling rate change is the one that was successful, and
> * wins. The parent, and two children are all changed to 32 MHz.
> */
> KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->parent_clk), 32 * HZ_PER_MHZ);
> KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->child1_clk), 32 * HZ_PER_MHZ);
> KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->child2_clk), 32 * HZ_PER_MHZ);
>
> With my changes, the clk framework will land on 96 MHz for the parent,
> and 24 MHz and 32 MHz for the two children.
>
> Anyways, it would be great if someone from Qualcomm would be willing
> to help me test my changes on real hardware. If it requires code
> changes to a specific clk provider, then I'm willing to also do that
> work if someone can test for me. Getting confirmation that this is
> fixed on real hardware will help to land my series that will provide a
> solution to this problem that has existing in the clk framework since
> it was introduced over 12 years ago.
Was going through my inbox - do you still need the testing? I see that
the last revision of the series (v6) is from march
Do I need anything other than just the series itself?
Konrad
next prev parent reply other threads:[~2026-06-30 14:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 11:55 Pengyu Luo
2026-03-03 12:10 ` Konrad Dybcio
2026-03-04 14:50 ` Brian Masney
2026-03-04 15:08 ` Pengyu Luo
2026-03-06 23:27 ` Brian Masney
2026-03-13 16:54 ` Brian Masney
2026-03-23 12:48 ` Konrad Dybcio
2026-03-23 16:07 ` Brian Masney
2026-06-30 14:37 ` Konrad Dybcio [this message]
2026-06-30 15:10 ` Brian Masney
2026-03-04 3:33 ` Dmitry Baryshkov
2026-03-10 2:45 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=798d2516-0772-4f98-8fad-959a1daf71bc@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liu224806@gmail.com \
--cc=lumag@kernel.org \
--cc=mitltlatltl@gmail.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®