* [PATCH v1] fpga: dfl: Drop #include for <linux/mod_devicetable.h>
@ 2026-08-22 14:05 Uwe Kleine-König (The Capable Hub)
2026-09-09 8:02 ` Xu Yilun
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-08-22 14:05 UTC (permalink / raw)
To: Xu Yilun, Moritz Fischer; +Cc: Tom Rix, linux-fpga, linux-kernel
None of the c files that #include drivers/fpga/dfl.h (either directly or
via drivers/fpga/dfl-afu.h) actually need <linux/mod_devicetable.h>.
There is drivers/fpga/dfl-pci.c using pci_device_id, which is provided
by <linux/pci.h> and drivers/fpga/dfl.c using dfl_device_id which is
already provided by <linux/dfl.h>. No other structs traditionally
defined in <linux/mod_devicetable.h> are used by these drivers.
So the #include can just be dropped.
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
drivers/fpga/dfl.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
index 9549f63b00eb..9a65617bb870 100644
--- a/drivers/fpga/dfl.h
+++ b/drivers/fpga/dfl.h
@@ -23,7 +23,6 @@
#include <linux/interrupt.h>
#include <linux/iopoll.h>
#include <linux/io-64-nonatomic-lo-hi.h>
-#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/uuid.h>
base-commit: 903c1cf6dff9964e71eda98a39e2e5d442050472
--
2.55.0.11.g153666a7d9bb
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] fpga: dfl: Drop #include for <linux/mod_devicetable.h>
2026-08-22 14:05 [PATCH v1] fpga: dfl: Drop #include for <linux/mod_devicetable.h> Uwe Kleine-König (The Capable Hub)
@ 2026-09-09 8:02 ` Xu Yilun
0 siblings, 0 replies; 2+ messages in thread
From: Xu Yilun @ 2026-09-09 8:02 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Xu Yilun, Moritz Fischer, Tom Rix, linux-fpga, linux-kernel
On Sat, Aug 22, 2026 at 04:05:35PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> None of the c files that #include drivers/fpga/dfl.h (either directly or
> via drivers/fpga/dfl-afu.h) actually need <linux/mod_devicetable.h>.
>
> There is drivers/fpga/dfl-pci.c using pci_device_id, which is provided
> by <linux/pci.h> and drivers/fpga/dfl.c using dfl_device_id which is
> already provided by <linux/dfl.h>. No other structs traditionally
> defined in <linux/mod_devicetable.h> are used by these drivers.
>
> So the #include can just be dropped.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Applied to for-next. Thanks.
> ---
> drivers/fpga/dfl.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 9549f63b00eb..9a65617bb870 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -23,7 +23,6 @@
> #include <linux/interrupt.h>
> #include <linux/iopoll.h>
> #include <linux/io-64-nonatomic-lo-hi.h>
> -#include <linux/mod_devicetable.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/uuid.h>
>
> base-commit: 903c1cf6dff9964e71eda98a39e2e5d442050472
> --
> 2.55.0.11.g153666a7d9bb
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-09 8:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-22 14:05 [PATCH v1] fpga: dfl: Drop #include for <linux/mod_devicetable.h> Uwe Kleine-König (The Capable Hub)
2026-09-09 8:02 ` Xu Yilun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®