* [PATCH v3] mm/slub: Genericize x86-specific cmpxchg16b comment
@ 2026-11-11 1:11 Tiezhu Yang
2026-11-11 8:19 ` Hao Li
2026-11-11 8:42 ` Vlastimil Babka (SUSE)
0 siblings, 2 replies; 3+ messages in thread
From: Tiezhu Yang @ 2026-11-11 1:11 UTC (permalink / raw)
To: Vlastimil Babka, Harry Yoo, Andrew Morton, Hao Li,
Christoph Lameter, David Rientjes, Roman Gushchin
Cc: linux-mm, loongarch, bpf, linux-kernel
In __kmalloc_nolock_noprof(), update the comment from x86-specific
"cmpxchg16b" to generic "double-width atomic cmpxchg".
Suggested-by: Harry Yoo <harry@kernel.org>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
v3:
- add missing Suggested-by tag for Harry
- use shorter commit message as requested
mm/slub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 45e077c7526c..090302f1daeb 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -5589,8 +5589,8 @@ static void *__kmalloc_nolock_noprof(DECL_TOKEN_PARAMS(size, token), gfp_t gfp_f
if (!(s->flags & __CMPXCHG_DOUBLE) && !kmem_cache_debug(s))
/*
* kmalloc_nolock() is not supported on architectures that
- * don't implement cmpxchg16b and thus need slab_lock()
- * which could be preempted by a nmi.
+ * don't implement double-width atomic cmpxchg and thus need
+ * slab_lock() which could be preempted by a nmi.
* But debug caches don't use that and only rely on
* kmem_cache_node->list_lock, so kmalloc_nolock() can attempt
* to allocate from debug caches by
--
2.42.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] mm/slub: Genericize x86-specific cmpxchg16b comment
2026-11-11 1:11 [PATCH v3] mm/slub: Genericize x86-specific cmpxchg16b comment Tiezhu Yang
@ 2026-11-11 8:19 ` Hao Li
2026-11-11 8:42 ` Vlastimil Babka (SUSE)
1 sibling, 0 replies; 3+ messages in thread
From: Hao Li @ 2026-11-11 8:19 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Vlastimil Babka, Harry Yoo, Andrew Morton, Christoph Lameter,
David Rientjes, Roman Gushchin, linux-mm, loongarch, bpf,
linux-kernel
On Wed, Nov 11, 2026 at 09:11:08AM +0800, Tiezhu Yang wrote:
> In __kmalloc_nolock_noprof(), update the comment from x86-specific
> "cmpxchg16b" to generic "double-width atomic cmpxchg".
>
> Suggested-by: Harry Yoo <harry@kernel.org>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> v3:
> - add missing Suggested-by tag for Harry
> - use shorter commit message as requested
>
> mm/slub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 45e077c7526c..090302f1daeb 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -5589,8 +5589,8 @@ static void *__kmalloc_nolock_noprof(DECL_TOKEN_PARAMS(size, token), gfp_t gfp_f
> if (!(s->flags & __CMPXCHG_DOUBLE) && !kmem_cache_debug(s))
> /*
> * kmalloc_nolock() is not supported on architectures that
> - * don't implement cmpxchg16b and thus need slab_lock()
> - * which could be preempted by a nmi.
> + * don't implement double-width atomic cmpxchg and thus need
> + * slab_lock() which could be preempted by a nmi.
> * But debug caches don't use that and only rely on
> * kmem_cache_node->list_lock, so kmalloc_nolock() can attempt
> * to allocate from debug caches by
> --
> 2.42.0
>
Looks good to me.
Reviewed-by: Hao Li <hao.li@linux.dev>
--
Thanks,
Hao
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] mm/slub: Genericize x86-specific cmpxchg16b comment
2026-11-11 1:11 [PATCH v3] mm/slub: Genericize x86-specific cmpxchg16b comment Tiezhu Yang
2026-11-11 8:19 ` Hao Li
@ 2026-11-11 8:42 ` Vlastimil Babka (SUSE)
1 sibling, 0 replies; 3+ messages in thread
From: Vlastimil Babka (SUSE) @ 2026-11-11 8:42 UTC (permalink / raw)
To: Tiezhu Yang, Harry Yoo, Andrew Morton, Hao Li, Christoph Lameter,
David Rientjes, Roman Gushchin
Cc: linux-mm, loongarch, bpf, linux-kernel
On 11/11/26 02:11, Tiezhu Yang wrote:
> In __kmalloc_nolock_noprof(), update the comment from x86-specific
> "cmpxchg16b" to generic "double-width atomic cmpxchg".
>
> Suggested-by: Harry Yoo <harry@kernel.org>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Acked-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
> ---
> v3:
> - add missing Suggested-by tag for Harry
> - use shorter commit message as requested
>
> mm/slub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 45e077c7526c..090302f1daeb 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -5589,8 +5589,8 @@ static void *__kmalloc_nolock_noprof(DECL_TOKEN_PARAMS(size, token), gfp_t gfp_f
> if (!(s->flags & __CMPXCHG_DOUBLE) && !kmem_cache_debug(s))
> /*
> * kmalloc_nolock() is not supported on architectures that
> - * don't implement cmpxchg16b and thus need slab_lock()
> - * which could be preempted by a nmi.
> + * don't implement double-width atomic cmpxchg and thus need
> + * slab_lock() which could be preempted by a nmi.
> * But debug caches don't use that and only rely on
> * kmem_cache_node->list_lock, so kmalloc_nolock() can attempt
> * to allocate from debug caches by
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-11 8:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-11 1:11 [PATCH v3] mm/slub: Genericize x86-specific cmpxchg16b comment Tiezhu Yang
2026-11-11 8:19 ` Hao Li
2026-11-11 8:42 ` Vlastimil Babka (SUSE)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®