From: Andrew Lunn <andrew@lunn.ch>
To: Joseph Telaak <joseph@telaak.dev>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Chuanhong Guo <gch981213@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-mips@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: Add Siflower SF19A2890 GMAC
Date: Thu, 5 Nov 2026 22:43:29 +0100 [thread overview]
Message-ID: <7b4ab738-85c9-4747-bf89-1a5532af6901@lunn.ch> (raw)
In-Reply-To: <CAPY4CJ6mCc5HgQUZd2Mq3C=Tsmwp=-acAV8dsWcpO_J87Pr6rg@mail.gmail.com>
On Thu, Nov 05, 2026 at 03:57:45PM -0500, Joseph Telaak wrote:
> > Do you have access to another board which has a PHY connected, not a
> > switch?
>
> No. The GL-SFT1200 is the only SF19A2890 board I have, and the only
> other one I know of, the vendor's evaluation board in OpenWrt, also has
> a fixed-link on this port.
>
> > There are unexplained delays here. Is it the switch, this MAC, or the
> > PCB?
> >
> > We need to understand if tx-internal-delay 0 really means 0, or it
> > actually means 1065ps.
>
> I can't tell that from this board. The sweeps measure the sum of the
> MAC's delay line, the switch and the PCB, and I have no documentation
> of the line's own delay at step 0.
>
> What they do show, in the MAC's steps: the windows repeat every 8 ns,
> which puts the start of both eyes about 4 steps (0.2 ns) below 0. TX
> ends at step 51 and RX at step 28. So with every delay at 0 the link
> works, but right at the early edge of both eyes.
>
> Until that is known, how would you like v2 to describe this board?
The delay value makes no sense to me. It probably works because
something is broken somewhere, either the MAC or the switch.
We have to be careful with what we accept, because we generally
consider DT blobs ABI, old blobs need to work with new kernels.
When we find out what is actually broken and need to fix it, we would
normally have to do that without break running boards. And that is
often very difficult and messy.
So i think we need a get out from backwards compatibility. We need to
be able to break running boards with old DT blobs, in the future when
we fix whatever is broken. Maybe the best way to do that it make the
MAC glue driver and the DSA driver depend on BROKEN.
Andrew
next prev parent reply other threads:[~2026-11-05 21:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:22 [PATCH net-next 0/2] net: stmmac: Add the Siflower SF19A2890 glue Joseph Telaak via B4 Relay
2026-11-04 7:22 ` [PATCH net-next 1/2] dt-bindings: net: Add Siflower SF19A2890 GMAC Joseph Telaak via B4 Relay
2026-11-04 21:29 ` Andrew Lunn
2026-11-04 22:16 ` Joseph Telaak
2026-11-05 0:34 ` Joseph Telaak
2026-11-05 15:58 ` Andrew Lunn
2026-11-05 20:57 ` Joseph Telaak
2026-11-05 21:43 ` Andrew Lunn [this message]
2026-11-06 0:12 ` Joseph Telaak
2026-11-04 7:22 ` [PATCH net-next 2/2] net: stmmac: Add Siflower SF19A2890 glue Joseph Telaak via B4 Relay
2026-11-04 7:53 ` Maxime Chevallier
2026-11-04 8:40 ` Joseph Telaak
2026-11-04 21:35 ` Andrew Lunn
2026-11-04 22:19 ` Joseph Telaak
2026-11-04 7:58 ` [PATCH net-next 0/2] net: stmmac: Add the " Maxime Chevallier
2026-11-04 8:02 ` Joseph Telaak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b4ab738-85c9-4747-bf89-1a5532af6901@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=gch981213@gmail.com \
--cc=joabreu@synopsys.com \
--cc=joseph@telaak.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®