From: Andrew Lunn <andrew@lunn.ch>
To: Joseph Telaak <joseph@telaak.dev>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Chuanhong Guo <gch981213@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-mips@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: Add Siflower SF19A2890 GMAC
Date: Thu, 5 Nov 2026 16:58:15 +0100 [thread overview]
Message-ID: <ba32cd69-23a3-464f-a74b-68a29e7b8202@lunn.ch> (raw)
In-Reply-To: <CAPY4CJ74O1tFVCpcN9seoeWDF0VR9GNfKuE+rWODQamN2sjL3g@mail.gmail.com>
On Wed, Nov 04, 2026 at 05:16:14PM -0500, Joseph Telaak wrote:
> > Please add minimum, and multipleOf.
> >
> > I've not looked at the code yet, but default: 0 would also be good.
>
> Will do: minimum 0, multipleOf 55 and default 0.
>
> > These values are odd. The RGMII standard says 2ns is required. Where
> > is the rest coming from.
>
> They are the values the vendor bootloader programs, and I checked them
> against the hardware. Sweeping each delay over its 256 steps at
> 1000 Mb/s, TX works from 0 to about 2.8 ns and RX from 0 to about
> 1.5 ns; 935 and 550 ps sit inside both windows, and a 2 ns RX delay in
> the MAC fails.
>
> The rest of the skew is not programmed anywhere: the switch's PCDU
> register for this port reads back 0, and with the MAC's delays at 0 as
> well the link still passes traffic. So it comes from the board routing
> or the chips themselves, which I can't separate from software.
Do you have access to another board which has a PHY connected, not a
switch?
There are unexplained delays here. Is it the switch, this MAC, or the
PCB?
We need to understand if tx-internal-delay 0 really means 0, or it
actually means 1065ps.
Just because it works does not mean it is correct. We could be in a
two wrongs makes a right situation, and as soon is it is a different
device on the other end, it all falls apart.
Andrew
next prev parent reply other threads:[~2026-11-05 15:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:22 [PATCH net-next 0/2] net: stmmac: Add the Siflower SF19A2890 glue Joseph Telaak via B4 Relay
2026-11-04 7:22 ` [PATCH net-next 1/2] dt-bindings: net: Add Siflower SF19A2890 GMAC Joseph Telaak via B4 Relay
2026-11-04 21:29 ` Andrew Lunn
2026-11-04 22:16 ` Joseph Telaak
2026-11-05 0:34 ` Joseph Telaak
2026-11-05 15:58 ` Andrew Lunn [this message]
2026-11-05 20:57 ` Joseph Telaak
2026-11-05 21:43 ` Andrew Lunn
2026-11-06 0:12 ` Joseph Telaak
2026-11-04 7:22 ` [PATCH net-next 2/2] net: stmmac: Add Siflower SF19A2890 glue Joseph Telaak via B4 Relay
2026-11-04 7:53 ` Maxime Chevallier
2026-11-04 8:40 ` Joseph Telaak
2026-11-04 21:35 ` Andrew Lunn
2026-11-04 22:19 ` Joseph Telaak
2026-11-04 7:58 ` [PATCH net-next 0/2] net: stmmac: Add the " Maxime Chevallier
2026-11-04 8:02 ` Joseph Telaak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba32cd69-23a3-464f-a74b-68a29e7b8202@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=gch981213@gmail.com \
--cc=joabreu@synopsys.com \
--cc=joseph@telaak.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®