* [PATCH] powerpc/crash: update fdt on cpu hotplug remove
@ 2026-11-03 8:53 Shivang Upadhyay
2026-11-03 9:12 ` Jinjie Ruan
0 siblings, 1 reply; 2+ messages in thread
From: Shivang Upadhyay @ 2026-11-03 8:53 UTC (permalink / raw)
To: linuxppc-dev, linux-kernel
Cc: maddy, mpe, npiggin, chleroy, ritesh.list, sshegde, sourabhjain,
rppt, ruanjinjie, baoquan.he, Shivang Upadhyay, Anushree Mathur
Currently fdt for crash kernel is not updated on cpu hotplug remove,
which can lead to the following XIVE warnings on the crash kernel
bringup.
[ 0.630795][ T1] xive: H_INT_GET_QUEUE_INFO cpu=16 prio=6 failed -55
[ 0.630912][ T1] xive: Error -55 getting queue info CPU 16 prio 6
[ 0.680899][ T1] xive: H_INT_GET_QUEUE_INFO cpu=17 prio=6 failed -55
[ 0.681000][ T1] xive: Error -55 getting queue info CPU 17 prio 6
Fixing this by updating crash fdt on cpu hotplug remove path also.
Reported-by: Anushree Mathur <anushree.mathur@linux.ibm.com>
Suggested-by: Sourabh Jain <sourabhjain@linux.ibm.com>
Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
---
arch/powerpc/kexec/crash.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/kexec/crash.c b/arch/powerpc/kexec/crash.c
index 775895f31037..0ef10e39ae49 100644
--- a/arch/powerpc/kexec/crash.c
+++ b/arch/powerpc/kexec/crash.c
@@ -639,8 +639,6 @@ void arch_crash_handle_hotplug_event(struct kimage *image, void *arg)
switch (image->hp_action) {
case KEXEC_CRASH_HP_REMOVE_CPU:
- return;
-
case KEXEC_CRASH_HP_ADD_CPU:
update_crash_fdt(image);
break;
--
2.54.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/crash: update fdt on cpu hotplug remove
2026-11-03 8:53 [PATCH] powerpc/crash: update fdt on cpu hotplug remove Shivang Upadhyay
@ 2026-11-03 9:12 ` Jinjie Ruan
0 siblings, 0 replies; 2+ messages in thread
From: Jinjie Ruan @ 2026-11-03 9:12 UTC (permalink / raw)
To: Shivang Upadhyay, linuxppc-dev, linux-kernel
Cc: maddy, mpe, npiggin, chleroy, ritesh.list, sshegde, sourabhjain,
rppt, baoquan.he, Anushree Mathur
在 2026/11/3 16:53, Shivang Upadhyay 写道:
> Currently fdt for crash kernel is not updated on cpu hotplug remove,
> which can lead to the following XIVE warnings on the crash kernel
> bringup.
>
> [ 0.630795][ T1] xive: H_INT_GET_QUEUE_INFO cpu=16 prio=6 failed -55
> [ 0.630912][ T1] xive: Error -55 getting queue info CPU 16 prio 6
> [ 0.680899][ T1] xive: H_INT_GET_QUEUE_INFO cpu=17 prio=6 failed -55
> [ 0.681000][ T1] xive: Error -55 getting queue info CPU 17 prio 6
>
> Fixing this by updating crash fdt on cpu hotplug remove path also.
>
> Reported-by: Anushree Mathur <anushree.mathur@linux.ibm.com>
> Suggested-by: Sourabh Jain <sourabhjain@linux.ibm.com>
> Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
> ---
> arch/powerpc/kexec/crash.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/kexec/crash.c b/arch/powerpc/kexec/crash.c
> index 775895f31037..0ef10e39ae49 100644
> --- a/arch/powerpc/kexec/crash.c
> +++ b/arch/powerpc/kexec/crash.c
> @@ -639,8 +639,6 @@ void arch_crash_handle_hotplug_event(struct kimage *image, void *arg)
>
> switch (image->hp_action) {
> case KEXEC_CRASH_HP_REMOVE_CPU:
> - return;
> -
LGTM
Reviewed-by: Jinjie Ruan <ruanjinjie@huawei.com>
> case KEXEC_CRASH_HP_ADD_CPU:
> update_crash_fdt(image);
> break;
--
Best regards,
Jinjie
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-03 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-03 8:53 [PATCH] powerpc/crash: update fdt on cpu hotplug remove Shivang Upadhyay
2026-11-03 9:12 ` Jinjie Ruan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®