* [PATCH -next] wifi: ath5k: Remove redundant dev_err()
@ 2023-07-26 17:12 Ruan Jinjie
2023-08-04 1:15 ` Ruan Jinjie
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ruan Jinjie @ 2023-07-26 17:12 UTC (permalink / raw)
To: jirislaby, mickflemm, mcgrof, kvalo, linux-wireless, linux-kernel
Cc: ruanjinjie
There is no need to call the dev_err() function directly to print a custom
message when handling an error from platform_get_irq() function as it is
going to display an appropriate error message in case of a failure.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
drivers/net/wireless/ath/ath5k/ahb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
index 28a1e5eff204..08bd5d3b00f1 100644
--- a/drivers/net/wireless/ath/ath5k/ahb.c
+++ b/drivers/net/wireless/ath/ath5k/ahb.c
@@ -115,7 +115,6 @@ static int ath_ahb_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "no IRQ resource found: %d\n", irq);
ret = irq;
goto err_iounmap;
}
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] wifi: ath5k: Remove redundant dev_err()
2023-07-26 17:12 [PATCH -next] wifi: ath5k: Remove redundant dev_err() Ruan Jinjie
@ 2023-08-04 1:15 ` Ruan Jinjie
2023-08-07 14:02 ` Jeff Johnson
2023-08-22 13:34 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Ruan Jinjie @ 2023-08-04 1:15 UTC (permalink / raw)
To: jirislaby, mickflemm, mcgrof, kvalo, linux-wireless, linux-kernel
Ping.
On 2023/7/27 1:12, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as it is
> going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
> drivers/net/wireless/ath/ath5k/ahb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> index 28a1e5eff204..08bd5d3b00f1 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> @@ -115,7 +115,6 @@ static int ath_ahb_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "no IRQ resource found: %d\n", irq);
> ret = irq;
> goto err_iounmap;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] wifi: ath5k: Remove redundant dev_err()
2023-07-26 17:12 [PATCH -next] wifi: ath5k: Remove redundant dev_err() Ruan Jinjie
2023-08-04 1:15 ` Ruan Jinjie
@ 2023-08-07 14:02 ` Jeff Johnson
2023-08-22 13:34 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Jeff Johnson @ 2023-08-07 14:02 UTC (permalink / raw)
To: Ruan Jinjie, jirislaby, mickflemm, mcgrof, kvalo, linux-wireless,
linux-kernel
On 7/26/2023 10:12 AM, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as it is
> going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/net/wireless/ath/ath5k/ahb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> index 28a1e5eff204..08bd5d3b00f1 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> @@ -115,7 +115,6 @@ static int ath_ahb_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "no IRQ resource found: %d\n", irq);
> ret = irq;
> goto err_iounmap;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] wifi: ath5k: Remove redundant dev_err()
2023-07-26 17:12 [PATCH -next] wifi: ath5k: Remove redundant dev_err() Ruan Jinjie
2023-08-04 1:15 ` Ruan Jinjie
2023-08-07 14:02 ` Jeff Johnson
@ 2023-08-22 13:34 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2023-08-22 13:34 UTC (permalink / raw)
To: Ruan Jinjie
Cc: jirislaby, mickflemm, mcgrof, linux-wireless, linux-kernel, ruanjinjie
Ruan Jinjie <ruanjinjie@huawei.com> wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as it is
> going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
f708ed71775d wifi: ath5k: Remove redundant dev_err()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230726171235.2475625-1-ruanjinjie@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-22 13:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-26 17:12 [PATCH -next] wifi: ath5k: Remove redundant dev_err() Ruan Jinjie
2023-08-04 1:15 ` Ruan Jinjie
2023-08-07 14:02 ` Jeff Johnson
2023-08-22 13:34 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®