mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
To: Karthik S <karthik.s@oss.qualcomm.com>,
	Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/5] ASoC: qcom: sc8280xp: Conditionally set S16_LE format in hw_params fixup
Date: Tue, 27 Oct 2026 13:59:17 +0530	[thread overview]
Message-ID: <7dc5131f-4cc5-4c97-8da4-28910a312239@oss.qualcomm.com> (raw)
In-Reply-To: <20261022094313.1074873-5-karthik.s@oss.qualcomm.com>

>   	rate->min = rate->max = 48000;
> -	snd_mask_set_format(fmt, SNDRV_PCM_FORMAT_S16_LE);
> +	switch (cpu_dai->id) {
> +	case PRIMARY_MI2S_RX ... QUATERNARY_MI2S_TX:
> +	case QUINARY_MI2S_RX ... QUINARY_MI2S_TX:
> +	case DISPLAY_PORT_RX_0:
> +	case DISPLAY_PORT_RX_1 ... DISPLAY_PORT_RX_7:
> +		break;
> +	default:
> +		snd_mask_set_format(fmt, SNDRV_PCM_FORMAT_S16_LE);


S16_LE was originally added here for compressed playback ( 
https://lore.kernel.org/r/20250911154340.2798304-1-alexey.klimov@linaro.org 
).
Could you confirm that compressed playback is unaffected by skipping 
this constraint for the MI2S and DisplayPort backends ?

Thanks,
Prasad

> +		break;
> +	}
>   	channels->min = 2;
>   	channels->max = 2;
>   	switch (cpu_dai->id) {

  reply	other threads:[~2026-10-27  8:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  9:43 [PATCH v1 0/5] ASoC: qcom: Add Shikra IQS LT9611UXD EVK audio support Karthik S
2026-10-22  9:43 ` [PATCH v1 1/5] ASoC: dt-bindings: qcom,sm8250: Add shikra-iqs-lt9611uxd-evk sound card Karthik S
2026-10-22 16:17   ` Ajay Kumar Nandam
2026-10-26  6:44     ` Karthik S
2026-10-22  9:43 ` [PATCH v1 2/5] arm64: dts: qcom: shikra-iqs: Add LT9611UXD HDMI audio overlay Karthik S
2026-10-22 10:31   ` Dmitry Baryshkov
2026-10-26  6:48     ` Karthik S
2026-10-22  9:43 ` [PATCH v1 3/5] ASoC: qcom: q6apm-dai: Add 32-bit sample format support Karthik S
2026-10-27  8:32   ` Prasad Kumpatla
2026-10-22  9:43 ` [PATCH v1 4/5] ASoC: qcom: sc8280xp: Conditionally set S16_LE format in hw_params fixup Karthik S
2026-10-27  8:29   ` Prasad Kumpatla [this message]
2026-10-27 12:59     ` Karthik S
2026-10-22  9:43 ` [PATCH v1 5/5] ASoC: qcom: sc8280xp: Add shikra-iqs-lt9611uxd-evk compatible support Karthik S
2026-10-22 16:07   ` Ajay Kumar Nandam
2026-10-26  7:24     ` Karthik S
2026-10-22 13:02 ` [PATCH v1 0/5] ASoC: qcom: Add Shikra IQS LT9611UXD EVK audio support Mark Brown
2026-10-26 21:32 ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2026-10-22  7:42 Karthik S
2026-10-22  7:42 ` [PATCH v1 4/5] ASoC: qcom: sc8280xp: Conditionally set S16_LE format in hw_params fixup Karthik S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7dc5131f-4cc5-4c97-8da4-28910a312239@oss.qualcomm.com \
    --to=prasad.kumpatla@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=karthik.s@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®