[PATCH v2] ARM: dts: aspeed: anacapa: Add retimer EEPROMs

[PATCH v2] ARM: dts: aspeed: anacapa: Add retimer EEPROMs

[Dirk Chen via B4 Relay]

From: Dirk Chen <dirkchen@amd.com>

The Anacapa board features Atmel 24C2048 EEPROMs on i2c0 and i2c1, which
are used to store retimer configurations. Add the corresponding device
tree nodes to support these components.

Signed-off-by: Dirk Chen <dirkchen@amd.com>
---
Changes in v2:
- Improved commit description to clarify that the change reflects
  actual hardware as requested by the reviewer.
- Removed mentions of other platforms to avoid confusion.
- Link to v1: https://lore.kernel.org/r/20260202-b4-anacapa-dts-fix-v1-1-20d4b0114854@amd.com
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
index 221af858cb6b..b8d248d99d7c 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
@@ -328,6 +328,12 @@ i2c0mux0ch3: i2c@3 {
 			#size-cells = <0>;
 		};
 	};
+
+	eeprom@50 {
+		compatible = "atmel,24c2048";
+		reg = <0x50>;
+		pagesize = <128>;
+	};
 };
 
 // R Bridge Board
@@ -362,6 +368,12 @@ i2c1mux0ch3: i2c@3 {
 			#size-cells = <0>;
 		};
 	};
+
+	eeprom@50 {
+		compatible = "atmel,24c2048";
+		reg = <0x50>;
+		pagesize = <128>;
+	};
 };
 
 // MB - E1.S

---
base-commit: 4c87cdd0328495759f6e9f9f4e1e53ef8032a76f
change-id: 20260202-b4-anacapa-dts-fix-207ffe9a3b0c

Best regards,
-- 
Dirk Chen <dirkchen@amd.com>

Re: [PATCH v2] ARM: dts: aspeed: anacapa: Add retimer EEPROMs

[Andrew Jeffery]

Hi Dirk,

On Mon, 2026-02-09 at 15:58 +0800, Dirk Chen via B4 Relay wrote:
> From: Dirk Chen <dirkchen@amd.com>
> 
> The Anacapa board features Atmel 24C2048 EEPROMs on i2c0 and i2c1, which
> are used to store retimer configurations. Add the corresponding device
> tree nodes to support these components.
> 
> Signed-off-by: Dirk Chen <dirkchen@amd.com>
> ---
> Changes in v2:
> - Improved commit description to clarify that the change reflects
>   actual hardware as requested by the reviewer.
> - Removed mentions of other platforms to avoid confusion.
> - Link to v1: https://lore.kernel.org/r/20260202-b4-anacapa-dts-fix-v1-1-20d4b0114854@amd.com
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> index 221af858cb6b..b8d248d99d7c 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> @@ -328,6 +328,12 @@ i2c0mux0ch3: i2c@3 {
>  			#size-cells = <0>;
>  		};
>  	};
> +
> +	eeprom@50 {

Please order these nodes by ascending address. The node currently above
this one is i2c-mux@70 - eeprom@50 should go before it.

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes

> +		compatible = "atmel,24c2048";
> +		reg = <0x50>;
> +		pagesize = <128>;
> +	};
>  };
>  
>  // R Bridge Board
> @@ -362,6 +368,12 @@ i2c1mux0ch3: i2c@3 {
>  			#size-cells = <0>;
>  		};
>  	};
> +
> +	eeprom@50 {

Same for this one.

> +		compatible = "atmel,24c2048";
> +		reg = <0x50>;
> +		pagesize = <128>;
> +	};
>  };
>  
>  // MB - E1.S
> 
> ---
> base-commit: 4c87cdd0328495759f6e9f9f4e1e53ef8032a76f
> change-id: 20260202-b4-anacapa-dts-fix-207ffe9a3b0c
> 
> Best regards,

RE: [PATCH v2] ARM: dts: aspeed: anacapa: Add retimer EEPROMs

[Chen, Dirk]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Andrew,

> +     eeprom@50 {
> Please order these nodes by ascending address. The node currently above this one is i2c-mux@70 - eeprom@50 should go before it.
> https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes

Thanks for the reminder.
I've reordered the nodes by ascending address in v3.

> +             compatible = "atmel,24c2048";
> +             reg = <0x50>;
> +             pagesize = <128>;
> +     };
>  };
> +     eeprom@50 {
> Same for this one.

Fixed in v3 as well.

Best regards.
Dirk

Re: [PATCH v2] ARM: dts: aspeed: anacapa: Add retimer EEPROMs

[Andrew Jeffery]

Hi Dirk,

On Thu, 2026-02-19 at 15:54 +0000, Chen, Dirk wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]

Please have a read through [1], in particular:

[1]: https://subspace.kernel.org/etiquette.html

   Do not include “confidentiality disclaimers”

   When posting to public mailing lists the boilerplate confidentiality
   disclaimers are not only meaningless, they are absolutely wrong for
   obvious reasons.
   
   If that disclaimer is automatically inserted by your corporate e-mail
   infrastructure, talk to your manager, IT department or consider using a
   different e-mail address which is not affected by this policy. Many IT
   companies have dedicated e-mail infrastructure for kernel developers to
   specifically avoid this situation.

> 
> Hi Andrew,
> 
> > +     eeprom@50 {
> > Please order these nodes by ascending address. The node currently above this one is i2c-mux@70 - eeprom@50 should go before it.
> > https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes
> 
> Thanks for the reminder.
> I've reordered the nodes by ascending address in v3.
> 
> > +             compatible = "atmel,24c2048";
> > +             reg = <0x50>;
> > +             pagesize = <128>;
> > +     };
> >  };
> > +     eeprom@50 {
> > Same for this one.
> 
> Fixed in v3 as well.
> 

Thanks,

Andrew

RE: [PATCH v2] ARM: dts: aspeed: anacapa: Add retimer EEPROMs

[Chen, Dirk]

Hi Andrew,
On Thu, 2026-02-19 at 15:54 +0000, Chen, Dirk wrote:
> Please have a read through [1], in particular:
> [1]: https://subspace.kernel.org/etiquette.html
>    Do not include “confidentiality disclaimers”

My apologies for the corporate labels and disclaimers in the previous mail.
I have adjusted my mail client settings.
Thank you for the reminder and the link.

Best regards,
Dirk