From: Paolo Abeni <pabeni@redhat.com>
To: David Howells <dhowells@redhat.com>, netdev@vger.kernel.org
Cc: Marc Dionne <marc.dionne@auristor.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/2] rxrpc: RACK-TLP fixes
Date: Thu, 1 Oct 2026 11:18:44 +0200 [thread overview]
Message-ID: <804cd85f-21d0-4fd9-9e53-cdcbfed27e9f@redhat.com> (raw)
In-Reply-To: <20260925191520.2206700-1-dhowells@redhat.com>
On 9/25/26 21:15, David Howells wrote:
> Here are some fixes for AF_RXRPC's RACK-TLP implementation. It's split
> into two patches: the first just fixes the RFC number in comments but has
> no actual code changes; the second does the actual fixing, including:
>
> - Making the in/exiting fast/RTO recovery flags available to RACK-TLP code
> after the Reorder timer expires.
>
> - Arming the RTO timer if no other timer is running and there is unacked
> data.
>
> - Initialising the TLP state in the correct place.
>
> - Not resetting the xmit timestamp when marking a packet lost.
>
> - Correctly checking the flight size.
>
> - Correctly tracking the number of packets in the Tx window that have been
> re-sent and thus correctly estimating the flight size.
I'm not sure if the sashiko feedback is worth addressing, or could be a
follow-up. Also Linus is pushing back quite a bit on fixes this late in the
cycle; we are trying to defer things to 'next', where appropriate.
I think patch 1/2 will not pass Linus' filter, and possibly even patch 2/2
WDYT about targeting net-next here?
If sashiko is deferrable, no need to repost.
/P
prev parent reply other threads:[~2026-10-01 9:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 19:15 David Howells
2026-09-25 19:15 ` [PATCH net 1/2] rxrpc: Fix the comments saying RFC8958 to be RFC8985 David Howells
2026-09-29 19:29 ` netdev-bot+sashiko
2026-09-25 19:15 ` [PATCH net 2/2] rxrpc: Fix RACK-TLP implementation David Howells
2026-09-29 19:29 ` netdev-bot+sashiko
2026-10-01 9:18 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=804cd85f-21d0-4fd9-9e53-cdcbfed27e9f@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®