* [PATCH 2/2] checkpatch: reword long-line warning about commit-msg
@ 2023-09-07 17:45 Jim Cromie
2023-09-07 18:19 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Jim Cromie @ 2023-09-07 17:45 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, Jim Cromie, apw, joe, Kees Cook
The COMMIT_LOG_LONG_LINE warning complains about:
1- possible unwrapped commit description
2- line too long
The actual test is #2, so reword it to say that 1st.
This could reduce potential confusion for newbie users.
Cc: apw@canonical.com
Cc: joe@perches.com
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6aabcc1f66c1..6e789dc07420 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3272,7 +3272,7 @@ sub process {
# A Fixes:, link or signature tag line
$commit_log_possible_stack_dump)) {
WARN("COMMIT_LOG_LONG_LINE",
- "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
+ "Prefer a maximum 75 chars per line (possible unwrapped commit description?)\n" . $herecurr);
$commit_log_long_line = 1;
}
--
2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] checkpatch: reword long-line warning about commit-msg
2023-09-07 17:45 [PATCH 2/2] checkpatch: reword long-line warning about commit-msg Jim Cromie
@ 2023-09-07 18:19 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2023-09-07 18:19 UTC (permalink / raw)
To: Jim Cromie, linux-kernel; +Cc: akpm, apw, Kees Cook
On Thu, 2023-09-07 at 11:45 -0600, Jim Cromie wrote:
> The COMMIT_LOG_LONG_LINE warning complains about:
> 1- possible unwrapped commit description
> 2- line too long
>
> The actual test is #2, so reword it to say that 1st.
> This could reduce potential confusion for newbie users.
I don't see this as valuable.
>
> Cc: apw@canonical.com
> Cc: joe@perches.com
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6aabcc1f66c1..6e789dc07420 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3272,7 +3272,7 @@ sub process {
> # A Fixes:, link or signature tag line
> $commit_log_possible_stack_dump)) {
> WARN("COMMIT_LOG_LONG_LINE",
> - "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
> + "Prefer a maximum 75 chars per line (possible unwrapped commit description?)\n" . $herecurr);
> $commit_log_long_line = 1;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 0/2] checkpatch tweaks
@ 2023-08-08 3:30 Jim Cromie
2023-08-08 3:30 ` [PATCH 2/2] checkpatch: reword long-line warning about commit-msg Jim Cromie
0 siblings, 1 reply; 3+ messages in thread
From: Jim Cromie @ 2023-08-08 3:30 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, Jim Cromie
2 small changes:
. silence extern in .c warning if sym is present in vmlinux.lds.h
. warn about >75 chars 1st, since thats the actual test.
Jim Cromie (2):
checkpatch: special case extern struct in .c
checkpatch: reword long-line warning about commit-msg
scripts/checkpatch.pl | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
--
2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] checkpatch: reword long-line warning about commit-msg
2023-08-08 3:30 [PATCH 0/2] checkpatch tweaks Jim Cromie
@ 2023-08-08 3:30 ` Jim Cromie
0 siblings, 0 replies; 3+ messages in thread
From: Jim Cromie @ 2023-08-08 3:30 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, Jim Cromie, apw, joe
Reword the warning to complain about line length 1st, since thats
whats actually tested.
Cc: apw@canonical.com
Cc: joe@perches.com
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6aabcc1f66c1..6e789dc07420 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3272,7 +3272,7 @@ sub process {
# A Fixes:, link or signature tag line
$commit_log_possible_stack_dump)) {
WARN("COMMIT_LOG_LONG_LINE",
- "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
+ "Prefer a maximum 75 chars per line (possible unwrapped commit description?)\n" . $herecurr);
$commit_log_long_line = 1;
}
--
2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-07 18:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-07 17:45 [PATCH 2/2] checkpatch: reword long-line warning about commit-msg Jim Cromie
2023-09-07 18:19 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2023-08-08 3:30 [PATCH 0/2] checkpatch tweaks Jim Cromie
2023-08-08 3:30 ` [PATCH 2/2] checkpatch: reword long-line warning about commit-msg Jim Cromie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®