Re: [PATCH V2 1/1] remoteproc: qcom: Add NOTIFY_FATAL event type to SSR subdevice

[Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>]

On 6/5/2026 2:32 AM, Jeff Johnson wrote:
> On 8/19/2024 11:09 PM, Gokul Sriram Palanisamy wrote:
>> From: Vignesh Viswanathan <quic_viswanat@quicinc.com>
>>
>> Currently the SSR subdevice notifies the client driver on crash of the
>> rproc from the recovery workqueue using the BEFORE_SHUTDOWN event.
>> However, the client driver might be interested to know that the device
>> has crashed immediately to pause any further transactions with the
>> rproc. This calls for an event to be sent to the driver in the IRQ
>> context as soon as the rproc crashes.
>>
>> Add NOTIFY_FATAL event to SSR subdevice to atomically notify rproc has
> 
> Almost 2 years later and I'm finally seeing the ath12k patch in internal
> review that uses this.
> 
> I was confused when the ath12k code didn't actually have any references to
> "NOTIFY_FATAL" and then I got a build error due to a missing
> QCOM_SSR_NOTIFY_CRASH.
> 
> So all instance of NOTIFY_FATAL in the subject and commit text should be
> changed to NOTIFY_CRASH.
>
> And as was noted by Dmitry, this patch should be packaged with the ath12k
> patch when it leaves internal review.

Agreed Jeff, I'll rebase this patch and change NOTIFY_FATAL to NOTIFY_CRASH
and send out a v2 for internal review.

Thanks,
Vignesh
> 
>