mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>,
	andersson@kernel.org, linux-arm-msm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: quic_varada@quicinc.com, quic_srichara@quicinc.com,
	quic_viswanat@quicinc.com, quic_mojha@quicinc.com
Subject: Re: [PATCH V2 1/1] remoteproc: qcom: Add NOTIFY_FATAL event type to SSR subdevice
Date: Thu, 4 Jun 2026 14:02:13 -0700	[thread overview]
Message-ID: <9d3728cf-bf4b-4ba0-8c71-831d908072a9@oss.qualcomm.com> (raw)
In-Reply-To: <20240820060943.277260-1-quic_gokulsri@quicinc.com>

On 8/19/2024 11:09 PM, Gokul Sriram Palanisamy wrote:
> From: Vignesh Viswanathan <quic_viswanat@quicinc.com>
> 
> Currently the SSR subdevice notifies the client driver on crash of the
> rproc from the recovery workqueue using the BEFORE_SHUTDOWN event.
> However, the client driver might be interested to know that the device
> has crashed immediately to pause any further transactions with the
> rproc. This calls for an event to be sent to the driver in the IRQ
> context as soon as the rproc crashes.
> 
> Add NOTIFY_FATAL event to SSR subdevice to atomically notify rproc has

Almost 2 years later and I'm finally seeing the ath12k patch in internal
review that uses this.

I was confused when the ath12k code didn't actually have any references to
"NOTIFY_FATAL" and then I got a build error due to a missing
QCOM_SSR_NOTIFY_CRASH.

So all instance of NOTIFY_FATAL in the subject and commit text should be
changed to NOTIFY_CRASH.

And as was noted by Dmitry, this patch should be packaged with the ath12k
patch when it leaves internal review.


  parent reply	other threads:[~2026-06-04 21:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20  6:09 Gokul Sriram Palanisamy
2024-08-28 21:05 ` Dmitry Baryshkov
2026-06-04 21:02 ` Jeff Johnson [this message]
2026-06-05  4:19   ` Vignesh Viswanathan
2026-06-04 21:12 ` Jeff Johnson
2026-06-05  4:20   ` Vignesh Viswanathan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d3728cf-bf4b-4ba0-8c71-831d908072a9@oss.qualcomm.com \
    --to=jeff.johnson@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=quic_gokulsri@quicinc.com \
    --cc=quic_mojha@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=quic_viswanat@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®