From: Rajendra Nayak <quic_rjendra@quicinc.com>
To: Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: qcom-rpmh: Fix regulators for PM8550
Date: Mon, 5 Jun 2023 19:15:08 +0530 [thread overview]
Message-ID: <8156aff1-2e3f-16ee-04b7-844aa4dfed91@quicinc.com> (raw)
In-Reply-To: <20230605115607.921308-1-abel.vesa@linaro.org>
On 6/5/2023 5:26 PM, Abel Vesa wrote:
> The PM8550 uses only NLDOs 515 and the LDO 6 through 8 are low voltage
> type, so fix accordingly.
I was seeing a bunch of LDO initialization's fail while bringing up an
upcoming SoC/Board which uses these same set of PMIC's, some of those
are fixed with this patch, but I still have a couple more failing due
to the voltage that I try to init them to being out of range based on
their voltage range, can you pls check if those are of the right type?
The ones now failing are, ldo12 from pm8550 and smps4 from pm8550ve.
>
> Fixes: e6e3776d682d ("regulator: qcom-rpmh: Add support for PM8550 regulators")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/regulator/qcom-rpmh-regulator.c | 30 ++++++++++++-------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> index b0a58c62b1e2..f3b280af0773 100644
> --- a/drivers/regulator/qcom-rpmh-regulator.c
> +++ b/drivers/regulator/qcom-rpmh-regulator.c
> @@ -1057,21 +1057,21 @@ static const struct rpmh_vreg_init_data pm8450_vreg_data[] = {
> };
>
> static const struct rpmh_vreg_init_data pm8550_vreg_data[] = {
> - RPMH_VREG("ldo1", "ldo%s1", &pmic5_pldo, "vdd-l1-l4-l10"),
> + RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo515, "vdd-l1-l4-l10"),
> RPMH_VREG("ldo2", "ldo%s2", &pmic5_pldo, "vdd-l2-l13-l14"),
> - RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo, "vdd-l3"),
> - RPMH_VREG("ldo4", "ldo%s4", &pmic5_nldo, "vdd-l1-l4-l10"),
> + RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo515, "vdd-l3"),
> + RPMH_VREG("ldo4", "ldo%s4", &pmic5_nldo515, "vdd-l1-l4-l10"),
> RPMH_VREG("ldo5", "ldo%s5", &pmic5_pldo, "vdd-l5-l16"),
> - RPMH_VREG("ldo6", "ldo%s6", &pmic5_pldo_lv, "vdd-l6-l7"),
> - RPMH_VREG("ldo7", "ldo%s7", &pmic5_pldo_lv, "vdd-l6-l7"),
> - RPMH_VREG("ldo8", "ldo%s8", &pmic5_pldo_lv, "vdd-l8-l9"),
> + RPMH_VREG("ldo6", "ldo%s6", &pmic5_pldo, "vdd-l6-l7"),
> + RPMH_VREG("ldo7", "ldo%s7", &pmic5_pldo, "vdd-l6-l7"),
> + RPMH_VREG("ldo8", "ldo%s8", &pmic5_pldo, "vdd-l8-l9"),
> RPMH_VREG("ldo9", "ldo%s9", &pmic5_pldo, "vdd-l8-l9"),
> - RPMH_VREG("ldo10", "ldo%s10", &pmic5_nldo, "vdd-l1-l4-l10"),
> - RPMH_VREG("ldo11", "ldo%s11", &pmic5_nldo, "vdd-l11"),
> + RPMH_VREG("ldo10", "ldo%s10", &pmic5_nldo515, "vdd-l1-l4-l10"),
> + RPMH_VREG("ldo11", "ldo%s11", &pmic5_nldo515, "vdd-l11"),
> RPMH_VREG("ldo12", "ldo%s12", &pmic5_pldo, "vdd-l12"),
> RPMH_VREG("ldo13", "ldo%s13", &pmic5_pldo, "vdd-l2-l13-l14"),
> RPMH_VREG("ldo14", "ldo%s14", &pmic5_pldo, "vdd-l2-l13-l14"),
> - RPMH_VREG("ldo15", "ldo%s15", &pmic5_pldo, "vdd-l15"),
> + RPMH_VREG("ldo15", "ldo%s15", &pmic5_nldo515, "vdd-l15"),
> RPMH_VREG("ldo16", "ldo%s16", &pmic5_pldo, "vdd-l5-l16"),
> RPMH_VREG("ldo17", "ldo%s17", &pmic5_pldo, "vdd-l17"),
> RPMH_VREG("bob1", "bob%s1", &pmic5_bob, "vdd-bob1"),
> @@ -1086,9 +1086,9 @@ static const struct rpmh_vreg_init_data pm8550vs_vreg_data[] = {
> RPMH_VREG("smps4", "smp%s4", &pmic5_ftsmps525_lv, "vdd-s4"),
> RPMH_VREG("smps5", "smp%s5", &pmic5_ftsmps525_lv, "vdd-s5"),
> RPMH_VREG("smps6", "smp%s6", &pmic5_ftsmps525_mv, "vdd-s6"),
> - RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo, "vdd-l1"),
> - RPMH_VREG("ldo2", "ldo%s2", &pmic5_nldo, "vdd-l2"),
> - RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo, "vdd-l3"),
> + RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo515, "vdd-l1"),
> + RPMH_VREG("ldo2", "ldo%s2", &pmic5_nldo515, "vdd-l2"),
> + RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo515, "vdd-l3"),
> {}
> };
>
> @@ -1101,9 +1101,9 @@ static const struct rpmh_vreg_init_data pm8550ve_vreg_data[] = {
> RPMH_VREG("smps6", "smp%s6", &pmic5_ftsmps525_lv, "vdd-s6"),
> RPMH_VREG("smps7", "smp%s7", &pmic5_ftsmps525_lv, "vdd-s7"),
> RPMH_VREG("smps8", "smp%s8", &pmic5_ftsmps525_lv, "vdd-s8"),
> - RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo, "vdd-l1"),
> - RPMH_VREG("ldo2", "ldo%s2", &pmic5_nldo, "vdd-l2"),
> - RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo, "vdd-l3"),
> + RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo515, "vdd-l1"),
> + RPMH_VREG("ldo2", "ldo%s2", &pmic5_nldo515, "vdd-l2"),
> + RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo515, "vdd-l3"),
> {}
> };
>
next prev parent reply other threads:[~2023-06-05 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 11:56 Abel Vesa
2023-06-05 13:45 ` Rajendra Nayak [this message]
2023-06-07 17:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8156aff1-2e3f-16ee-04b7-844aa4dfed91@quicinc.com \
--to=quic_rjendra@quicinc.com \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®