Re: [PATCH v2 01/22] media: dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga3

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/12/2025 16:52, Sven Püschel wrote:
> Add a new compatible for the RGA3 (Raster Graphic Acceleration 3)
> peripheral found on the RK3588 SoC.
> 
> The existing rga node refers to the RGA2 peripheral. The RK3588

What is "existing rga node"? There is no node here. This is a patch for
bindings, so you say which hardware existing binding describes and what
are the differences against that older hardware.

> contains one RGA2 core and two RGA3 cores. Both feature a similar
> functionality of scaling, cropping and rotating of up to two input
> images into one output image. Key differences of the RGA3 are:
> 
> - supports 10bit YUV output formats
> - supports 8x8 tiles and FBCD as inputs and outputs
> - supports BT2020 color space conversion
> - max output resolution of (8192-64)x(8192-64)
> - MMU can map up to 32G DDR RAM
> - fully planar formats (3 planes) are not supported
> - max scale up/down factor of 8

"differences" in meaning nothing above is supported by RGA2?

> 
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>


Best regards,
Krzysztof