From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: "Sven Püschel" <s.pueschel@pengutronix.de>,
"Jacob Chen" <jacob-chen@iotwrt.com>,
"Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH v2 02/22] media: v4l2-common: add has_alpha to v4l2_format_info
Date: Wed, 24 Dec 2025 09:24:20 -0500 [thread overview]
Message-ID: <fffbec0dbb95fe0aa34e847c89499e91ebc1df43.camel@ndufresne.ca> (raw)
In-Reply-To: <20251203-spu-rga3-v2-2-989a67947f71@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 6508 bytes --]
Le mercredi 03 décembre 2025 à 16:52 +0100, Sven Püschel a écrit :
> Add a has_alpha value to the v4l2_format_info struct to indicate if the
> format contains an alpha component. The implementation is based on the
> drm_format_info implementation.
>
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> drivers/media/v4l2-core/v4l2-common.c | 14 +++++++-------
> include/media/v4l2-common.h | 2 ++
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c
> index 554c591e11133..2c7ac70c0f486 100644
> --- a/drivers/media/v4l2-core/v4l2-common.c
> +++ b/drivers/media/v4l2-core/v4l2-common.c
> @@ -256,10 +256,10 @@ const struct v4l2_format_info *v4l2_format_info(u32 format)
> { .format = V4L2_PIX_FMT_XRGB32, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> { .format = V4L2_PIX_FMT_RGBX32, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> { .format = V4L2_PIX_FMT_HSV32, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> - { .format = V4L2_PIX_FMT_ARGB32, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> - { .format = V4L2_PIX_FMT_RGBA32, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> - { .format = V4L2_PIX_FMT_ABGR32, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> - { .format = V4L2_PIX_FMT_BGRA32, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> + { .format = V4L2_PIX_FMT_ARGB32, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1, .has_alpha = true },
> + { .format = V4L2_PIX_FMT_RGBA32, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1, .has_alpha = true },
> + { .format = V4L2_PIX_FMT_ABGR32, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1, .has_alpha = true },
> + { .format = V4L2_PIX_FMT_BGRA32, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1, .has_alpha = true },
> { .format = V4L2_PIX_FMT_RGB565, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 2, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> { .format = V4L2_PIX_FMT_RGB565X, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 2, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> { .format = V4L2_PIX_FMT_RGB555, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 2, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> @@ -267,10 +267,10 @@ const struct v4l2_format_info *v4l2_format_info(u32 format)
> { .format = V4L2_PIX_FMT_BGR48_12, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 6, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> { .format = V4L2_PIX_FMT_BGR48, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 6, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> { .format = V4L2_PIX_FMT_RGB48, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 6, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> - { .format = V4L2_PIX_FMT_ABGR64_12, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 8, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> - { .format = V4L2_PIX_FMT_RGBA1010102, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> + { .format = V4L2_PIX_FMT_ABGR64_12, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 8, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1, .has_alpha = true },
> + { .format = V4L2_PIX_FMT_RGBA1010102, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1, .has_alpha = true },
> { .format = V4L2_PIX_FMT_RGBX1010102, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> - { .format = V4L2_PIX_FMT_ARGB2101010, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> + { .format = V4L2_PIX_FMT_ARGB2101010, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1, .has_alpha = true },
>
> /* YUV packed formats */
> { .format = V4L2_PIX_FMT_YUYV, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 1, .comp_planes = 1, .bpp = { 2, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 2, .vdiv = 1 },
> diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
> index f8b1faced79c8..401d8506c24b5 100644
> --- a/include/media/v4l2-common.h
> +++ b/include/media/v4l2-common.h
> @@ -520,6 +520,7 @@ enum v4l2_pixel_encoding {
> * @vdiv: Vertical chroma subsampling factor
> * @block_w: Per-plane macroblock pixel width (optional)
> * @block_h: Per-plane macroblock pixel height (optional)
> + * @has_alpha: Does the format embeds an alpha component?
> */
> struct v4l2_format_info {
> u32 format;
> @@ -532,6 +533,7 @@ struct v4l2_format_info {
> u8 vdiv;
> u8 block_w[4];
> u8 block_h[4];
> + bool has_alpha;
> };
>
> static inline bool v4l2_is_format_rgb(const struct v4l2_format_info *f)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-12-24 14:24 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 15:52 [PATCH v2 00/22] media: platform: rga: Add RGA3 support Sven Püschel
2025-12-03 15:52 ` [PATCH v2 01/22] media: dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga3 Sven Püschel
2025-12-03 20:28 ` Krzysztof Kozlowski
2025-12-03 21:21 ` Sven Püschel
2025-12-03 15:52 ` [PATCH v2 02/22] media: v4l2-common: add has_alpha to v4l2_format_info Sven Püschel
2025-12-24 14:24 ` Nicolas Dufresne [this message]
2025-12-03 15:52 ` [PATCH v2 03/22] media: v4l2-common: add v4l2_fill_pixfmt_mp_aligned helper Sven Püschel
2025-12-24 14:47 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 04/22] media: rockchip: rga: use clk_bulk api Sven Püschel
2025-12-24 14:48 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 05/22] media: rockchip: rga: use stride for offset calculation Sven Püschel
2025-12-24 15:00 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 06/22] media: rockchip: rga: remove redundant rga_frame variables Sven Püschel
2025-12-24 15:03 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 07/22] media: rockchip: rga: move hw specific parts to a dedicated struct Sven Püschel
2025-12-24 15:05 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 08/22] media: rockchip: rga: move cmdbuf to rga_ctx Sven Püschel
2025-12-24 15:21 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 09/22] media: rockchip: rga: align stride to 4 bytes Sven Püschel
2025-12-24 15:26 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 10/22] media: rockchip: rga: prepare cmdbuf on streamon Sven Püschel
2025-12-24 15:29 ` Nicolas Dufresne
2026-01-07 12:00 ` Sven Püschel
2025-12-03 15:52 ` [PATCH v2 11/22] media: rockchip: rga: check scaling factor Sven Püschel
2025-12-24 15:39 ` Nicolas Dufresne
2026-01-09 12:18 ` Sven Püschel
2025-12-03 15:52 ` [PATCH v2 12/22] media: rockchip: rga: use card type to specify rga type Sven Püschel
2025-12-24 15:40 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 13/22] media: rockchip: rga: change offset to dma_addresses Sven Püschel
2025-12-24 15:41 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 14/22] media: rockchip: rga: support external iommus Sven Püschel
2025-12-24 15:50 ` Nicolas Dufresne
2026-01-07 14:19 ` Sven Püschel
2026-01-07 14:24 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 15/22] media: rockchip: rga: share the interrupt when an external iommu is used Sven Püschel
2025-12-24 15:50 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 16/22] media: rockchip: rga: remove size from rga_frame Sven Püschel
2025-12-24 15:54 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 17/22] media: rockchip: rga: remove stride " Sven Püschel
2025-12-24 15:56 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 18/22] media: rockchip: rga: move rga_fmt to rga-hw.h Sven Püschel
2025-12-24 15:59 ` Nicolas Dufresne
2026-01-07 14:52 ` Sven Püschel
2025-12-03 15:52 ` [PATCH v2 19/22] media: rockchip: rga: add feature flags Sven Püschel
2025-12-24 16:00 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 20/22] media: rockchip: rga: disable multi-core support Sven Püschel
2025-12-24 16:02 ` Nicolas Dufresne
2025-12-03 15:52 ` [PATCH v2 21/22] media: rockchip: rga: add rga3 support Sven Püschel
2025-12-24 16:34 ` Nicolas Dufresne
2026-01-21 14:40 ` Sven Püschel
2025-12-03 15:52 ` [PATCH v2 22/22] arm64: dts: rockchip: add rga3 dt nodes Sven Püschel
2025-12-05 22:36 ` [PATCH v2 00/22] media: platform: rga: Add RGA3 support Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fffbec0dbb95fe0aa34e847c89499e91ebc1df43.camel@ndufresne.ca \
--to=nicolas@ndufresne.ca \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=s.pueschel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®