mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>,
	Arnav Kapoor <kapoorarnav43@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Mudit Sharma" <muditsharma.info@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: light: bh1745: fix 16-bit register accesses
Date: Wed, 18 Nov 2026 12:31:59 +0200	[thread overview]
Message-ID: <820865f9-2ef5-4316-abbe-5c44c7df55ce@gmail.com> (raw)
In-Reply-To: <avxi4BBJ_Ztg-aN7@ashevche-desk.local>

On 17/11/2026 16:21, Andy Shevchenko wrote:
> + Cc: Matti (even he is not listed as maintainer) for possible another pair of
> eyes and/or having an answer why this was missed at the time of the driver
> submission (from my perspective this patch is correct).

Thanks for the heads-up Andy. Unfortunately, I have never worked with 
this IC, and I don't think we have it in the ROHM Finland office (but 
I'll check this just in case. It'd be nice to have this covered in my 
test setup).

What comes to missing this in reviews... Well, I suppose the reviewers 
are just humans, or if they're not, then they might have concentrated on 
other important things, like styling, instead of the real functionality.

On my own behalf, I was away for 1.5 months when the series was applied, 
and I only looked at the GTS-helpers usage when I did my shallow and 
badly belated review. (Furthermore, I am 100% human, so I might have 
just missed this even if I had all the time in the world to do the review).

Yours,
     -- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

  parent reply	other threads:[~2026-11-18 10:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:03 Arnav Kapoor
2026-11-17 14:21 ` Andy Shevchenko
2026-11-17 14:23   ` Andy Shevchenko
2026-11-18 10:31   ` Matti Vaittinen [this message]
2026-11-18 11:42     ` Andy Shevchenko
2026-11-18 10:31 ` Matti Vaittinen
2026-11-18 10:38   ` Arnav Kapoor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=820865f9-2ef5-4316-abbe-5c44c7df55ce@gmail.com \
    --to=mazziesaccount@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=kapoorarnav43@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muditsharma.info@gmail.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®