From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Arnav Kapoor <kapoorarnav43@gmail.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: "Mudit Sharma" <muditsharma.info@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: light: bh1745: fix 16-bit register accesses
Date: Wed, 18 Nov 2026 12:31:14 +0200 [thread overview]
Message-ID: <c2e9261c-2906-457c-a6c5-8a81d87e3375@gmail.com> (raw)
In-Reply-To: <20261117110327.198084-1-kapoorarnav43@gmail.com>
On 17/11/2026 13:03, Arnav Kapoor wrote:
> The 16-bit colour data and threshold registers are little-endian
> LSB/MSB pairs, but the driver accesses them through regmap_bulk_read()
> and regmap_bulk_write() with an int or u16 buffer and no byte-order
> conversion:
>
> - bh1745_read_raw() reads 2 bytes into an uninitialised int, so the
> upper 16 bits returned to user space are stack contents.
> - bh1745_read_thresh() reads 2 bytes straight into *val, which the IIO
> core leaves uninitialised, with the same result for the event
> threshold attributes.
> - bh1745_write_thresh() writes the first 2 bytes of an int, which are
> the upper (zero) bytes on big-endian.
> - bh1745_trigger_handler() pushes the raw register bytes, which are
> little-endian, in a u16 to a buffer whose scan type is IIO_CPU, so
> user space gets the samples byte-swapped on big-endian.
>
> Use an __le16 buffer for all of them and convert with le16_to_cpu() /
> cpu_to_le16().
>
> Fixes: eab35358aae7 ("iio: light: ROHM BH1745 colour sensor")
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Thanks a lot for hunting down and fixing this Arnav!
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
next prev parent reply other threads:[~2026-11-18 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 11:03 Arnav Kapoor
2026-11-17 14:21 ` Andy Shevchenko
2026-11-17 14:23 ` Andy Shevchenko
2026-11-18 10:31 ` Matti Vaittinen
2026-11-18 11:42 ` Andy Shevchenko
2026-11-18 10:31 ` Matti Vaittinen [this message]
2026-11-18 10:38 ` Arnav Kapoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2e9261c-2906-457c-a6c5-8a81d87e3375@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kapoorarnav43@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muditsharma.info@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®