* [PATCH] fix:mtip32xx: mark symbols static where possible
@ 2016-08-26 6:08 Baoyou Xie
2016-08-26 15:37 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-08-26 6:08 UTC (permalink / raw)
To: axboe, asamymuthupa, smani, rsambandam, vgunasekaran, viro
Cc: linux-kernel, arnd, xie.baoyou, baoyou.xie
We get 1 warning when biuld kernel with W=1:
drivers/block/mtip32xx/mtip32xx.c:3689:6: warning: no previous prototype for
'mtip_block_release' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is declared
and don't need a declaration, but can be made static.
so this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/block/mtip32xx/mtip32xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 2aca98e..88c4685 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3686,7 +3686,7 @@ static int mtip_block_open(struct block_device *dev, fmode_t mode)
return -ENODEV;
}
-void mtip_block_release(struct gendisk *disk, fmode_t mode)
+static void mtip_block_release(struct gendisk *disk, fmode_t mode)
{
}
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix:mtip32xx: mark symbols static where possible
2016-08-26 6:08 [PATCH] fix:mtip32xx: mark symbols static where possible Baoyou Xie
@ 2016-08-26 15:37 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2016-08-26 15:37 UTC (permalink / raw)
To: Baoyou Xie, asamymuthupa, smani, rsambandam, vgunasekaran, viro
Cc: linux-kernel, arnd, xie.baoyou
On 08/26/2016 12:08 AM, Baoyou Xie wrote:
> We get 1 warning when biuld kernel with W=1:
> drivers/block/mtip32xx/mtip32xx.c:3689:6: warning: no previous prototype for
> 'mtip_block_release' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
Applied for 4.9, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-26 15:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-26 6:08 [PATCH] fix:mtip32xx: mark symbols static where possible Baoyou Xie
2016-08-26 15:37 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®