mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Eric Dumazet" <dada1@cosmosbay.com>
Cc: "Andi Kleen" <andi@firstfloor.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Christoph Lameter" <christoph@lameter.com>,
	"linux kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC, PATCH] SLAB : [NUMA] keep nodeid in struct page instead of struct slab
Date: Wed, 21 Mar 2007 14:21:16 +0200	[thread overview]
Message-ID: <84144f020703210521q10ad95d4g760010bd4388c71f@mail.gmail.com> (raw)
In-Reply-To: <20070321102231.7288f231.dada1@cosmosbay.com>

On 3/21/07, Eric Dumazet <dada1@cosmosbay.com> wrote:
> In order to avoid a cache miss in kmem_cache_free() on NUMA and reduce hot path
> length, we could exploit the following common facts.

It would be nice if you could cc me for slab patches.

On 3/21/07, Eric Dumazet <dada1@cosmosbay.com> wrote:
> -static inline void page_set_cache(struct page *page, struct kmem_cache *cache)
> +static inline void page_set_cache_slab_nodeid(struct page *page,
> +       struct kmem_cache *cache, struct slab *slab, int nodeid)
>  {
> +       page->lru.prev = (struct list_head *)slab;
> +#ifdef KEEP_NODEID_IN_PAGE
> +       page->lru.next = (struct list_head *)((long)cache + nodeid);
> +#else
>         page->lru.next = (struct list_head *)cache;
> +#endif
> +#ifdef KEEP_NODEID_IN_SLAB
> +       slab->nodeid = nodeid;
> +#endif

Can we please have a slab_get_nid() and slab_set_nid() instead which
reduces the need for #ifdefs?

  reply	other threads:[~2007-03-21 12:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-21  9:22 Eric Dumazet
2007-03-21 12:21 ` Pekka Enberg [this message]
2007-03-21 14:42   ` Christoph Lameter
2007-03-21 15:03     ` Pekka Enberg
2007-03-21 15:43       ` Christoph Lameter
2007-03-21 15:42     ` Pekka J Enberg
2007-03-21 15:49       ` Eric Dumazet
2007-03-21 15:55         ` Pekka J Enberg
2007-03-21 16:09       ` Andi Kleen
2007-03-21 16:19         ` Pekka Enberg
2007-03-21 16:27         ` Christoph Lameter
2007-03-23 11:15         ` [RFC] NUMA : could we introduce virt_to_nid() ? Eric Dumazet
2007-03-23 12:48           ` Pekka Enberg
2007-03-23 13:53             ` Eric Dumazet
2007-03-23 14:16           ` Andi Kleen
2007-03-23 14:50           ` Christoph Lameter
2007-03-23 16:22             ` Eric Dumazet
2007-03-23 17:19               ` Christoph Lameter
2007-03-21 12:27 ` [RFC, PATCH] SLAB : [NUMA] keep nodeid in struct page instead of struct slab Pekka Enberg
2007-03-21 14:41 ` Christoph Lameter
2007-03-21 15:36   ` Eric Dumazet
2007-03-21 15:44     ` Christoph Lameter
2007-03-21 15:58       ` Eric Dumazet
2007-03-21 15:47     ` Pekka Enberg
2007-03-21 15:52       ` Eric Dumazet
2007-03-21 16:08 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f020703210521q10ad95d4g760010bd4388c71f@mail.gmail.com \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=christoph@lameter.com \
    --cc=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®