mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <christoph@lameter.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC, PATCH] SLAB : [NUMA] keep nodeid in struct page instead of struct slab
Date: Wed, 21 Mar 2007 07:41:46 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0703210737400.1573@graphe.net> (raw)
In-Reply-To: <20070321102231.7288f231.dada1@cosmosbay.com>

On Wed, 21 Mar 2007, Eric Dumazet wrote:

> In order to avoid a cache miss in kmem_cache_free() on NUMA and reduce hot path length, we could exploit the following common facts.
> 
> 1) MAX_NUMNODES <= 64

MAX_NUMNODES == 1024 on IA64 and may be on x86_64 in the future.
 
> 2) alignment of 'struct kmem_cache *' can be >= 64
> 
> The following patch changes the page->lru.next to contain not only the 
> 'struct kmem_cache *' pointer, but also the nodeid in the low order 
> bits.

Nack.

I would suggest you audit slab and make sure that we never fall back and 
always enter a slab on the node of page_to_nid(page). If 
all allocations use GFP_THISNODE then you should be safe and then we can 
remove the nodeid from the slab structure and simply use the available 
node information in the page struct.

  parent reply	other threads:[~2007-03-21 14:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-21  9:22 Eric Dumazet
2007-03-21 12:21 ` Pekka Enberg
2007-03-21 14:42   ` Christoph Lameter
2007-03-21 15:03     ` Pekka Enberg
2007-03-21 15:43       ` Christoph Lameter
2007-03-21 15:42     ` Pekka J Enberg
2007-03-21 15:49       ` Eric Dumazet
2007-03-21 15:55         ` Pekka J Enberg
2007-03-21 16:09       ` Andi Kleen
2007-03-21 16:19         ` Pekka Enberg
2007-03-21 16:27         ` Christoph Lameter
2007-03-23 11:15         ` [RFC] NUMA : could we introduce virt_to_nid() ? Eric Dumazet
2007-03-23 12:48           ` Pekka Enberg
2007-03-23 13:53             ` Eric Dumazet
2007-03-23 14:16           ` Andi Kleen
2007-03-23 14:50           ` Christoph Lameter
2007-03-23 16:22             ` Eric Dumazet
2007-03-23 17:19               ` Christoph Lameter
2007-03-21 12:27 ` [RFC, PATCH] SLAB : [NUMA] keep nodeid in struct page instead of struct slab Pekka Enberg
2007-03-21 14:41 ` Christoph Lameter [this message]
2007-03-21 15:36   ` Eric Dumazet
2007-03-21 15:44     ` Christoph Lameter
2007-03-21 15:58       ` Eric Dumazet
2007-03-21 15:47     ` Pekka Enberg
2007-03-21 15:52       ` Eric Dumazet
2007-03-21 16:08 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0703210737400.1573@graphe.net \
    --to=christoph@lameter.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®