From: Christoph Lameter <christoph@lameter.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Pekka J Enberg <penberg@cs.helsinki.fi>,
Andrew Morton <akpm@linux-foundation.org>,
linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] NUMA : could we introduce virt_to_nid() ?
Date: Fri, 23 Mar 2007 10:19:32 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0703231017250.1434@graphe.net> (raw)
In-Reply-To: <20070323172212.6648412d.dada1@cosmosbay.com>
On Fri, 23 Mar 2007, Eric Dumazet wrote:
> Sorry ? page structs are not in cpu cache at all.
They are if they are in any way handled by the VM.
> You carefully commented your alloc() function saying it is touching two cache lines.
> But you omited to say that free() function needs 3 cache lines if CONFIG_NUMA
Yes it needs the third cacheline to check the node of the page in the NUMA
case.
> For SLAB use, page struct is needed because we use lru.{next|prev} to
> store slab/cachep pointers, but for a pure page allocator, unless I
> misread your patch, we dont need it, if virt_to_nid() can do its job
> without it.
The page allocator is only handling page_structs.
next prev parent reply other threads:[~2007-03-23 17:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 9:22 [RFC, PATCH] SLAB : [NUMA] keep nodeid in struct page instead of struct slab Eric Dumazet
2007-03-21 12:21 ` Pekka Enberg
2007-03-21 14:42 ` Christoph Lameter
2007-03-21 15:03 ` Pekka Enberg
2007-03-21 15:43 ` Christoph Lameter
2007-03-21 15:42 ` Pekka J Enberg
2007-03-21 15:49 ` Eric Dumazet
2007-03-21 15:55 ` Pekka J Enberg
2007-03-21 16:09 ` Andi Kleen
2007-03-21 16:19 ` Pekka Enberg
2007-03-21 16:27 ` Christoph Lameter
2007-03-23 11:15 ` [RFC] NUMA : could we introduce virt_to_nid() ? Eric Dumazet
2007-03-23 12:48 ` Pekka Enberg
2007-03-23 13:53 ` Eric Dumazet
2007-03-23 14:16 ` Andi Kleen
2007-03-23 14:50 ` Christoph Lameter
2007-03-23 16:22 ` Eric Dumazet
2007-03-23 17:19 ` Christoph Lameter [this message]
2007-03-21 12:27 ` [RFC, PATCH] SLAB : [NUMA] keep nodeid in struct page instead of struct slab Pekka Enberg
2007-03-21 14:41 ` Christoph Lameter
2007-03-21 15:36 ` Eric Dumazet
2007-03-21 15:44 ` Christoph Lameter
2007-03-21 15:58 ` Eric Dumazet
2007-03-21 15:47 ` Pekka Enberg
2007-03-21 15:52 ` Eric Dumazet
2007-03-21 16:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703231017250.1434@graphe.net \
--to=christoph@lameter.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®