From: Tom Lendacky <thomas.lendacky@amd.com>
To: "Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>,
x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/9] x86/mm/pat: don't populate page tables in set_memory_{en,de}crypted()
Date: Tue, 17 Nov 2026 10:15:27 -0600 [thread overview]
Message-ID: <8418248a-aeae-46e0-bdee-4db1783d1bbc@amd.com> (raw)
In-Reply-To: <20261112-fixes-x86-v1-3-791adb8d6670@kernel.org>
On 11/12/26 10:31, Mike Rapoport (Microsoft) wrote:
> __set_memory_enc_pgtable() sets cpa.pgd to init_mm.pgd. With cpa.pgd
> set, CPA populates holes in init_mm instead of failing, and
> __cpa_process_fault() says that only EFI does that.
>
> So when an address in the range is not mapped, the request does not
> fail. populate_pgd() maps the physical memory at cpa.pfn there, with
> _KERNPG_TABLE and the encryption bits: present, writable and executable.
>
> A caller that passes an unmapped address is buggy, but it must not get a
> new mapping of some random physical memory.
>
> Drop the assignment. The request then walks init_mm as usual: a hole in
> the direct map is skipped and any other unmapped address fails with
> -EFAULT, as for the other set_memory APIs.
>
> Fixes: 77bd2342d430 ("x86/mm: Add support for changing the memory encryption attribute")
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> arch/x86/mm/pat/set_memory.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
> index fb2413cb8d314..aa7052d247e60 100644
> --- a/arch/x86/mm/pat/set_memory.c
> +++ b/arch/x86/mm/pat/set_memory.c
> @@ -2457,7 +2457,6 @@ static int __set_memory_enc_pgtable(unsigned long addr, int numpages, bool enc)
> cpa.numpages = numpages;
> cpa.mask_set = enc ? pgprot_encrypted(empty) : pgprot_decrypted(empty);
> cpa.mask_clr = enc ? pgprot_decrypted(empty) : pgprot_encrypted(empty);
> - cpa.pgd = init_mm.pgd;
>
> /* Must avoid aliasing mappings in the highmem code */
> kmap_flush_unused();
>
next prev parent reply other threads:[~2026-11-17 16:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 16:31 [PATCH 0/9] x86/mm: CPA robustness fixes and cleanups Mike Rapoport (Microsoft)
2026-11-12 16:31 ` [PATCH 1/9] x86/mm/pat: flush the TLB when only an alias mapping changed Mike Rapoport (Microsoft)
2026-11-12 16:31 ` [PATCH 2/9] x86/mm: don't set kernel_set_to_readonly when write protecting fails Mike Rapoport (Microsoft)
2026-11-12 16:31 ` [PATCH 3/9] x86/mm/pat: don't populate page tables in set_memory_{en,de}crypted() Mike Rapoport (Microsoft)
2026-11-17 16:15 ` Tom Lendacky [this message]
2026-11-12 16:31 ` [PATCH 4/9] x86/mm/pat: don't BUG() on inconsistent page count Mike Rapoport (Microsoft)
2026-11-12 16:31 ` [PATCH 5/9] x86/mm/pat: don't warn about W^X violations before mark_rodata_ro() Mike Rapoport (Microsoft)
2026-11-12 21:46 ` Salvatore Bonaccorso
2026-11-15 6:25 ` Mike Rapoport
2026-11-15 13:52 ` Salvatore Bonaccorso
2026-11-12 16:31 ` [PATCH 6/9] x86/mm/pat: remove CPA_ARRAY Mike Rapoport (Microsoft)
2026-11-12 16:31 ` [PATCH 7/9] x86/mm/pat: pass the address to CPA by value Mike Rapoport (Microsoft)
2026-11-12 16:31 ` [PATCH 8/9] x86/mm/pat: move the collapse of large pages out of cpa_flush() Mike Rapoport (Microsoft)
2026-11-12 16:31 ` [PATCH 9/9] x86/mm/pat: use cpa_flush() on CPA errors Mike Rapoport (Microsoft)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8418248a-aeae-46e0-bdee-4db1783d1bbc@amd.com \
--to=thomas.lendacky@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®