* [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig"
@ 2023-08-08 3:48 Xi Ruoyao
2023-08-08 7:16 ` Huacai Chen
0 siblings, 1 reply; 3+ messages in thread
From: Xi Ruoyao @ 2023-08-08 3:48 UTC (permalink / raw)
To: loongarch; +Cc: Huacai Chen, WANG Xuerui, linux-kernel, Xi Ruoyao
In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all ports so
there is no need to source it in the port-specific Kconfig file. And
sourcing it here also caused the "Firmware Drivers" menu appeared two
times: once in the "Device Drivers" menu, another time in the toplevel
menu. This was really puzzling.
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
---
arch/loongarch/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
index e71d5bf2cee0..465759f6b0ed 100644
--- a/arch/loongarch/Kconfig
+++ b/arch/loongarch/Kconfig
@@ -662,5 +662,3 @@ source "kernel/power/Kconfig"
source "drivers/acpi/Kconfig"
endmenu
-
-source "drivers/firmware/Kconfig"
--
2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig"
2023-08-08 3:48 [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig" Xi Ruoyao
@ 2023-08-08 7:16 ` Huacai Chen
2023-08-08 7:56 ` Xi Ruoyao
0 siblings, 1 reply; 3+ messages in thread
From: Huacai Chen @ 2023-08-08 7:16 UTC (permalink / raw)
To: Xi Ruoyao; +Cc: loongarch, WANG Xuerui, linux-kernel
Hi, Ruoyao,
I think the title should be "LoongArch: Remove redundant "source
drivers/firmware/Kconfig""?
Huacai
On Tue, Aug 8, 2023 at 11:49 AM Xi Ruoyao <xry111@xry111.site> wrote:
>
> In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all ports so
> there is no need to source it in the port-specific Kconfig file. And
> sourcing it here also caused the "Firmware Drivers" menu appeared two
> times: once in the "Device Drivers" menu, another time in the toplevel
> menu. This was really puzzling.
>
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
> arch/loongarch/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index e71d5bf2cee0..465759f6b0ed 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -662,5 +662,3 @@ source "kernel/power/Kconfig"
> source "drivers/acpi/Kconfig"
>
> endmenu
> -
> -source "drivers/firmware/Kconfig"
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig"
2023-08-08 7:16 ` Huacai Chen
@ 2023-08-08 7:56 ` Xi Ruoyao
0 siblings, 0 replies; 3+ messages in thread
From: Xi Ruoyao @ 2023-08-08 7:56 UTC (permalink / raw)
To: Huacai Chen; +Cc: loongarch, WANG Xuerui, linux-kernel
On Tue, 2023-08-08 at 15:16 +0800, Huacai Chen wrote:
> Hi, Ruoyao,
>
> I think the title should be "LoongArch: Remove redundant "source
> drivers/firmware/Kconfig""?
Yes, it looks better. I've sent v2 with the change.
Thanks!
>
> Huacai
>
> On Tue, Aug 8, 2023 at 11:49 AM Xi Ruoyao <xry111@xry111.site> wrote:
> >
> > In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all
> > ports so
> > there is no need to source it in the port-specific Kconfig file.
> > And
> > sourcing it here also caused the "Firmware Drivers" menu appeared
> > two
> > times: once in the "Device Drivers" menu, another time in the
> > toplevel
> > menu. This was really puzzling.
> >
> > Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> > ---
> > arch/loongarch/Kconfig | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> > index e71d5bf2cee0..465759f6b0ed 100644
> > --- a/arch/loongarch/Kconfig
> > +++ b/arch/loongarch/Kconfig
> > @@ -662,5 +662,3 @@ source "kernel/power/Kconfig"
> > source "drivers/acpi/Kconfig"
> >
> > endmenu
> > -
> > -source "drivers/firmware/Kconfig"
> > --
> > 2.41.0
> >
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-08 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-08 3:48 [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig" Xi Ruoyao
2023-08-08 7:16 ` Huacai Chen
2023-08-08 7:56 ` Xi Ruoyao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®