mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Automatically update drm CI dependencies?
@ 2023-12-14  9:38 Bagas Sanjaya
  2023-12-19 16:43 ` Helen Koike
  0 siblings, 1 reply; 4+ messages in thread
From: Bagas Sanjaya @ 2023-12-14  9:38 UTC (permalink / raw)
  To: Linux Kernel Mailing List, Linux DRI Development
  Cc: Helen Koike, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Daniel Vetter, David Heidelberg, Dorine Tipo

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

Hi all,

I'm referring to dependabot PR on torvalds.git GitHub mirror [1]. I know 
that PRs submitted there are not accepted (the repo is essentially read-only
mirror), hence this mail question.

In summary, dependabot submitted automated PR that bumps package versions
in `drivers/gpu/drm/ci/xfails/requirements.txt`. In this case, pip was
upgraded to 23.3.

From my experience, such automated PRs can pollute commit history (in
some GitHub projects these PR kind can contribute up to half of total
commits since the beginning of project). And in some projects, dependabot
PRs are automatically merged without any maintainer intervention.

Does such PRs (when submitted to LKML these will be patches) make sense
for DRM subsystem?

Thanks.

[1]: https://github.com/torvalds/linux/pull/807

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Automatically update drm CI dependencies?
  2023-12-14  9:38 Automatically update drm CI dependencies? Bagas Sanjaya
@ 2023-12-19 16:43 ` Helen Koike
  2023-12-20 11:11   ` Bagas Sanjaya
  0 siblings, 1 reply; 4+ messages in thread
From: Helen Koike @ 2023-12-19 16:43 UTC (permalink / raw)
  To: Bagas Sanjaya, Linux Kernel Mailing List, Linux DRI Development
  Cc: Thomas Zimmermann, Maxime Ripard, David Heidelberg, Dorine Tipo

Hi,

On 14/12/2023 06:38, Bagas Sanjaya wrote:
> Hi all,
> 
> I'm referring to dependabot PR on torvalds.git GitHub mirror [1]. I know
> that PRs submitted there are not accepted (the repo is essentially read-only
> mirror), hence this mail question.
> 
> In summary, dependabot submitted automated PR that bumps package versions
> in `drivers/gpu/drm/ci/xfails/requirements.txt`. In this case, pip was
> upgraded to 23.3.
> 
>  From my experience, such automated PRs can pollute commit history (in
> some GitHub projects these PR kind can contribute up to half of total
> commits since the beginning of project). And in some projects, dependabot
> PRs are automatically merged without any maintainer intervention.
> 
> Does such PRs (when submitted to LKML these will be patches) make sense
> for DRM subsystem?
> 
> Thanks.
> 
> [1]: https://github.com/torvalds/linux/pull/807
> 

imho I rather not having this automated patches, but I would like to 
hear the opinions from others.

Thanks
Helen

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Automatically update drm CI dependencies?
  2023-12-19 16:43 ` Helen Koike
@ 2023-12-20 11:11   ` Bagas Sanjaya
  2024-01-08 14:53     ` Helen Koike
  0 siblings, 1 reply; 4+ messages in thread
From: Bagas Sanjaya @ 2023-12-20 11:11 UTC (permalink / raw)
  To: Helen Koike, Linux Kernel Mailing List, Linux DRI Development
  Cc: Thomas Zimmermann, Maxime Ripard, David Heidelberg, Dorine Tipo

On 12/19/23 23:43, Helen Koike wrote:
> Hi,
> 
> On 14/12/2023 06:38, Bagas Sanjaya wrote:
>> Hi all,
>>
>> I'm referring to dependabot PR on torvalds.git GitHub mirror [1]. I know
>> that PRs submitted there are not accepted (the repo is essentially read-only
>> mirror), hence this mail question.
>>
>> In summary, dependabot submitted automated PR that bumps package versions
>> in `drivers/gpu/drm/ci/xfails/requirements.txt`. In this case, pip was
>> upgraded to 23.3.
>>
>>  From my experience, such automated PRs can pollute commit history (in
>> some GitHub projects these PR kind can contribute up to half of total
>> commits since the beginning of project). And in some projects, dependabot
>> PRs are automatically merged without any maintainer intervention.
>>
>> Does such PRs (when submitted to LKML these will be patches) make sense
>> for DRM subsystem?
>>
>> Thanks.
>>
>> [1]: https://github.com/torvalds/linux/pull/807
>>
> 
> imho I rather not having this automated patches, but I would like to hear the opinions from others.
> 

But why? Did you mean that making the CI always depends on latest version
of dependencies create another maintenance variable (and may constantly
broke CI)?

Confused...

-- 
An old man doll... just what I always wanted! - Clara


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Automatically update drm CI dependencies?
  2023-12-20 11:11   ` Bagas Sanjaya
@ 2024-01-08 14:53     ` Helen Koike
  0 siblings, 0 replies; 4+ messages in thread
From: Helen Koike @ 2024-01-08 14:53 UTC (permalink / raw)
  To: Bagas Sanjaya, Linux Kernel Mailing List, Linux DRI Development
  Cc: David Heidelberg, Dorine Tipo, Maxime Ripard, Thomas Zimmermann



On 20/12/2023 08:11, Bagas Sanjaya wrote:
> On 12/19/23 23:43, Helen Koike wrote:
>> Hi,
>>
>> On 14/12/2023 06:38, Bagas Sanjaya wrote:
>>> Hi all,
>>>
>>> I'm referring to dependabot PR on torvalds.git GitHub mirror [1]. I know
>>> that PRs submitted there are not accepted (the repo is essentially read-only
>>> mirror), hence this mail question.
>>>
>>> In summary, dependabot submitted automated PR that bumps package versions
>>> in `drivers/gpu/drm/ci/xfails/requirements.txt`. In this case, pip was
>>> upgraded to 23.3.
>>>
>>>   From my experience, such automated PRs can pollute commit history (in
>>> some GitHub projects these PR kind can contribute up to half of total
>>> commits since the beginning of project). And in some projects, dependabot
>>> PRs are automatically merged without any maintainer intervention.
>>>
>>> Does such PRs (when submitted to LKML these will be patches) make sense
>>> for DRM subsystem?
>>>
>>> Thanks.
>>>
>>> [1]: https://github.com/torvalds/linux/pull/807
>>>
>>
>> imho I rather not having this automated patches, but I would like to hear the opinions from others.
>>
> 
> But why? Did you mean that making the CI always depends on latest version
> of dependencies create another maintenance variable (and may constantly
> broke CI)?
> 
> Confused...

Sorry I didn't reply earlier.

I'm ok with that if it doesn't produce much noise, I also think that we 
need an automated test to see if the tool is still working as expected 
before merging the patch.
The pip there is just used for a helper tool, it is nothing critical.

Regards,
Helen

> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-01-08 14:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-14  9:38 Automatically update drm CI dependencies? Bagas Sanjaya
2023-12-19 16:43 ` Helen Koike
2023-12-20 11:11   ` Bagas Sanjaya
2024-01-08 14:53     ` Helen Koike

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®