mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jie Luo <quic_luoj@quicinc.com>
Cc: Christian Marangi <ansuelsmth@gmail.com>,
	"Russell King (Oracle)" <linux@armlinux.org.uk>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	hkallweit1@gmail.com, corbet@lwn.net, p.zabel@pengutronix.de,
	f.fainelli@gmail.com, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v8 14/14] dt-bindings: net: ar803x: add qca8084 PHY properties
Date: Wed, 3 Jan 2024 15:22:23 +0100	[thread overview]
Message-ID: <85590a5b-9d5a-40cb-8a0e-a3a3a1c3720a@lunn.ch> (raw)
In-Reply-To: <cee9de2c-bfa4-4ca9-9001-725e2041bc25@quicinc.com>

> Yes, APQ8084 is the application SoC.
> QCA8084 is the pure PHY chip which has quad-phy.

I think everybody agrees these are terrible names, being so close
together but being very different devices.

You have the issues of not giving clear explanations of your
hardware. This is resulting in a lot of wasted tome for everybody. So
please make your explanations very clear. I personally would avoid
using APQ8084 or QCA8084 on there own. Always say the application SoC
APQ8084, or the PHY chip QCA8084, or the switch embedded within the
application processor APQ8084, or the PHYs embedded within the
Application processor etc. This is particularly important when talking
about clocks and resets, since the PHYs embedded within the
application processor are likely to have different clocks and reset
controllers to the PHY chip QCA8084.

	Andrew

  reply	other threads:[~2024-01-03 14:22 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15  7:39 [PATCH v8 00/14] add qca8084 ethernet phy driver Luo Jie
2023-12-15  7:39 ` [PATCH v8 01/14] net: phy: introduce core support for phy-mode = "10g-qxgmii" Luo Jie
2023-12-15  7:39 ` [PATCH v8 02/14] dt-bindings: net: ethernet-controller: add 10g-qxgmii mode Luo Jie
2023-12-15  7:39 ` [PATCH v8 03/14] net: phy: at803x: add QCA8084 ethernet phy support Luo Jie
2023-12-15  7:39 ` [PATCH v8 04/14] net: phy: at803x: add the function phydev_id_is_qca808x Luo Jie
2023-12-15  7:39 ` [PATCH v8 05/14] net: phy: at803x: Add qca8084_config_init function Luo Jie
2023-12-15  7:39 ` [PATCH v8 06/14] net: phy: at803x: add qca8084_link_change_notify Luo Jie
2023-12-15  7:39 ` [PATCH v8 07/14] net: phy: at803x: add the possible_interfaces Luo Jie
2023-12-15  7:39 ` [PATCH v8 08/14] net: phy: at803x: add qca8084 switch registe access Luo Jie
2023-12-15  7:39 ` [PATCH v8 09/14] net: phy: at803x: set MDIO address of qca8084 PHY Luo Jie
2023-12-15  7:40 ` [PATCH v8 10/14] net: phy: at803x: parse qca8084 clocks and resets Luo Jie
2023-12-15  7:40 ` [PATCH v8 11/14] net: phy: at803x: add qca808x initial config sequence Luo Jie
2023-12-15  7:40 ` [PATCH v8 12/14] net: phy: at803x: configure qca8084 common clocks Luo Jie
2023-12-15  7:40 ` [PATCH v8 13/14] net: phy: at803x: configure qca8084 work mode Luo Jie
2023-12-17 13:02   ` Simon Horman
2023-12-18  3:33     ` Jie Luo
2023-12-15  7:40 ` [PATCH v8 14/14] dt-bindings: net: ar803x: add qca8084 PHY properties Luo Jie
2023-12-15  8:22   ` Krzysztof Kozlowski
2023-12-15 10:16     ` Jie Luo
2023-12-15 11:25       ` Andrew Lunn
2023-12-15 12:16         ` Jie Luo
2023-12-15 13:42           ` Russell King (Oracle)
2023-12-16  7:57             ` Jie Luo
2023-12-16 17:17               ` Andrew Lunn
2023-12-18  4:53                 ` Jie Luo
2023-12-18  9:34                   ` Andrew Lunn
2023-12-19  8:52                     ` Jie Luo
2023-12-15 12:12   ` Andrew Lunn
2023-12-15 12:33     ` Jie Luo
2023-12-15 13:31       ` Andrew Lunn
2023-12-16  7:37         ` Jie Luo
2023-12-16 10:21           ` Andrew Lunn
2023-12-16 13:25             ` Jie Luo
2023-12-16 13:51             ` Russell King (Oracle)
2023-12-16 14:41               ` Jie Luo
2023-12-16 16:01                 ` Christian Marangi
2023-12-18  5:22                   ` Jie Luo
2023-12-16 16:09                 ` Russell King (Oracle)
2023-12-18  3:01                   ` Jie Luo
2024-01-02  9:57                     ` Russell King (Oracle)
2024-01-02 10:08                       ` Christian Marangi
2024-01-03 13:27                         ` Jie Luo
2024-01-03 14:22                           ` Andrew Lunn [this message]
2024-01-04  9:53                             ` Jie Luo
2024-01-04 13:57                               ` Andrew Lunn
2024-01-05 10:26                                 ` Jie Luo
2024-01-05 13:37                                   ` Andrew Lunn
2024-01-08  8:27                                     ` Jie Luo
2023-12-16 17:30           ` Andrew Lunn
2023-12-16 19:08             ` Russell King (Oracle)
2023-12-18  3:31               ` Jie Luo
2023-12-18  3:27             ` Jie Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85590a5b-9d5a-40cb-8a0e-a3a3a1c3720a@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=quic_luoj@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®