From: Jie Luo <quic_luoj@quicinc.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <corbet@lwn.net>,
<p.zabel@pengutronix.de>, <f.fainelli@gmail.com>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v8 14/14] dt-bindings: net: ar803x: add qca8084 PHY properties
Date: Fri, 15 Dec 2023 20:16:53 +0800 [thread overview]
Message-ID: <ed0dd288-be8a-4161-a19f-2d4d2d17b3ec@quicinc.com> (raw)
In-Reply-To: <4cb2bd57-f3d3-49f9-9c02-a922fd270572@lunn.ch>
On 12/15/2023 7:25 PM, Andrew Lunn wrote:
>> The "maxItems: 1" of the property resets is defined in ethernet-phy.yaml
>> that is referenced by qca,ar803x.yaml, but i have 11 reset instances
>> used for qca8084 PHY
>
> 11!?!?? Really? Why?
>
> I assume the order and timer matters, otherwise why would you need
> 11? So the PHY driver needs to handle this, not phylib framework. So
> you will be adding vendor properties to describe all 11 of them. So
> ethernet-phy.yaml does not matter.
>
> Andrew
Since these resets need to be configured in the special sequence, and
these clocks need to be configured with different clock rate.
But the clock instance get, the property name is fixed to "clock-names"
according to the function of_parse_clkspec, and the reset property name
is also fixed to "reset-names" from function __of_reset_control_get.
next prev parent reply other threads:[~2023-12-15 12:17 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 7:39 [PATCH v8 00/14] add qca8084 ethernet phy driver Luo Jie
2023-12-15 7:39 ` [PATCH v8 01/14] net: phy: introduce core support for phy-mode = "10g-qxgmii" Luo Jie
2023-12-15 7:39 ` [PATCH v8 02/14] dt-bindings: net: ethernet-controller: add 10g-qxgmii mode Luo Jie
2023-12-15 7:39 ` [PATCH v8 03/14] net: phy: at803x: add QCA8084 ethernet phy support Luo Jie
2023-12-15 7:39 ` [PATCH v8 04/14] net: phy: at803x: add the function phydev_id_is_qca808x Luo Jie
2023-12-15 7:39 ` [PATCH v8 05/14] net: phy: at803x: Add qca8084_config_init function Luo Jie
2023-12-15 7:39 ` [PATCH v8 06/14] net: phy: at803x: add qca8084_link_change_notify Luo Jie
2023-12-15 7:39 ` [PATCH v8 07/14] net: phy: at803x: add the possible_interfaces Luo Jie
2023-12-15 7:39 ` [PATCH v8 08/14] net: phy: at803x: add qca8084 switch registe access Luo Jie
2023-12-15 7:39 ` [PATCH v8 09/14] net: phy: at803x: set MDIO address of qca8084 PHY Luo Jie
2023-12-15 7:40 ` [PATCH v8 10/14] net: phy: at803x: parse qca8084 clocks and resets Luo Jie
2023-12-15 7:40 ` [PATCH v8 11/14] net: phy: at803x: add qca808x initial config sequence Luo Jie
2023-12-15 7:40 ` [PATCH v8 12/14] net: phy: at803x: configure qca8084 common clocks Luo Jie
2023-12-15 7:40 ` [PATCH v8 13/14] net: phy: at803x: configure qca8084 work mode Luo Jie
2023-12-17 13:02 ` Simon Horman
2023-12-18 3:33 ` Jie Luo
2023-12-15 7:40 ` [PATCH v8 14/14] dt-bindings: net: ar803x: add qca8084 PHY properties Luo Jie
2023-12-15 8:22 ` Krzysztof Kozlowski
2023-12-15 10:16 ` Jie Luo
2023-12-15 11:25 ` Andrew Lunn
2023-12-15 12:16 ` Jie Luo [this message]
2023-12-15 13:42 ` Russell King (Oracle)
2023-12-16 7:57 ` Jie Luo
2023-12-16 17:17 ` Andrew Lunn
2023-12-18 4:53 ` Jie Luo
2023-12-18 9:34 ` Andrew Lunn
2023-12-19 8:52 ` Jie Luo
2023-12-15 12:12 ` Andrew Lunn
2023-12-15 12:33 ` Jie Luo
2023-12-15 13:31 ` Andrew Lunn
2023-12-16 7:37 ` Jie Luo
2023-12-16 10:21 ` Andrew Lunn
2023-12-16 13:25 ` Jie Luo
2023-12-16 13:51 ` Russell King (Oracle)
2023-12-16 14:41 ` Jie Luo
2023-12-16 16:01 ` Christian Marangi
2023-12-18 5:22 ` Jie Luo
2023-12-16 16:09 ` Russell King (Oracle)
2023-12-18 3:01 ` Jie Luo
2024-01-02 9:57 ` Russell King (Oracle)
2024-01-02 10:08 ` Christian Marangi
2024-01-03 13:27 ` Jie Luo
2024-01-03 14:22 ` Andrew Lunn
2024-01-04 9:53 ` Jie Luo
2024-01-04 13:57 ` Andrew Lunn
2024-01-05 10:26 ` Jie Luo
2024-01-05 13:37 ` Andrew Lunn
2024-01-08 8:27 ` Jie Luo
2023-12-16 17:30 ` Andrew Lunn
2023-12-16 19:08 ` Russell King (Oracle)
2023-12-18 3:31 ` Jie Luo
2023-12-18 3:27 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed0dd288-be8a-4161-a19f-2d4d2d17b3ec@quicinc.com \
--to=quic_luoj@quicinc.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®