Re: [PATCH v3 2/2] EDAC/amd64: Set zn_regs_v2 for all Family 1Ah models

["Badole, Vishal" <vishal.badole@amd.com>]

On 10/5/2026 8:37 PM, Yazen Ghannam wrote:
> On Sun, Oct 04, 2026 at 10:50:48AM -0700, Borislav Petkov wrote:
>> On Sun, Oct 04, 2026 at 01:05:25PM -0400, Yazen Ghannam wrote:
>>> I'd rather we load unconditionally for all models with the same base
>>> behavior using sane defaults. Then we can have model-specific patches
>>> for variations, if needed.
>>
>> I'd rather not because I keep getting all those: amd64_edac doesn't load on my
>> machine reports. Well, after a while it turns out that it should not load
>> there in the first place.
>>
>> And then there's the managerial checkbox patch which needs to add support for
>> their new model just because... does it even make sense to add support? Oh, we
>> didn't even think of that but it says "Unsupported" so we thought we should
>> "fix" the error message...
>>
>> So I don't want to have that unnecessary waste of everything. And if a f/m/s
>> would keep my sanity, then I'm perfectly fine with it.
>>
>>> Essentially, we could avoid a whole class of patches for derivative
>>> (client, embedded, etc.) products. The module would load with the sane
>>> defaults. If the test folks find an issue, then we can have a
>>> model-specific patch.
>>
>> Only on well-tested and supported configurations. Everything else doesn't
>> work.
>>
> 
> Okay, fair enough.
> 
> Vishal, you should be able to combine the current version with the
> suggestion from Boris.
> 
> 1) Move the zn v2 flag to the top of the 1Ah case.
> 2) Add 'failure' for the default case.
> 3) Leave the 40h model group and add the new group with it. Basically,
> there will be two model ranges sharing the 'empty' case.
> 4) Update the commit message with the new details. Make sure to describe
> 'why' rather than 'what'.
> 
> Thanks,
> Yazen

Sure, I will address the review comments and submit the changes as a 
separate patch. Since patch 1 has already been accepted, I will keep 
these updates isolated in a follow-up patch.

Thanks,
Vishal