Re: [PATCH] x86-64: typo in __assign_irq_vector when updating pos for vector and offset

[yhlu <yhlu.kernel@gmail.com>]

andi,

the per_cpu only can be used with online cpus?

YH

On 10/22/06, yhlu <yhlu.kernel@gmail.com> wrote:
> You must have NR_CPUS=4.
>
> Also you genapic is running on flat. (logical)
>
> Can you try to set NR_CPUS=8 and without this patch?
>
> YH
>
> On 10/22/06, Muli Ben-Yehuda <muli@il.ibm.com> wrote:
> > On Sun, Oct 22, 2006 at 01:28:03AM -0700, Yinghai Lu wrote:
> > > On 10/21/06, Muli Ben-Yehuda <muli@il.ibm.com> wrote:
> > > >>
> > > >> typo with cpu instead of new_cpu
> > > >
> > > >This patch breaks my x366 machine:
> > > >
> > > >aic94xx: device 0000:01:02.0: SAS addr 5005076a0112df00, PCBA SN , 8 phys,
> > > >8 enabled phys, flash present, BIOS build 1323
> > > >aic94xx: couldn't get irq 25 for 0000:01:02.0
> > > >ACPI: PCI interrupt for device 0000:01:02.0 disabled
> > > >aic94xx: probe of 0000:01:02.0 failed with error -38
> > > >
> > > >Reverting it allows it to boot again. Since the patch is "obviously
> > > >correct", it must be uncovering some other problem with the genirq
> > > >code.
> > > >
> > >
> > > can you try attached patch? it use cpu_online_map instead of 0xff.
> >
> > Works!
> >
> > Thanks,
> > Muli
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> >
>