mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: yhlu <yhlu.kernel@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Andi Kleen" <ak@suse.de>, "Muli Ben-Yehuda" <muli@il.ibm.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Andrew Morton" <akpm@osdl.org>
Subject: Re: [PATCH 2/2] x86_64 irq: Only look at per_cpu data for online cpus.
Date: Sun, 22 Oct 2006 23:17:23 -0700	[thread overview]
Message-ID: <86802c440610222317l1867ab38v4c33231b96237b7f@mail.gmail.com> (raw)
In-Reply-To: <m1k62ry7hl.fsf_-_@ebiederm.dsl.xmission.com>

On 10/22/06, Eric W. Biederman <ebiederm@xmission.com> wrote:
>
> When I generalized __assign_irq_vector I failed to pay attention
> to what happens when you access a per cpu data structure for
> a cpu that is not online.   It is an undefined case making any
> code that does it have undefined behavior as well.
>
> The code still needs to be able to allocate a vector across cpus
> that are not online to properly handle combinations like lowest
> priority interrupt delivery and cpu_hotplug.  Not that we can do
> that today but the infrastructure shouldn't prevent it.
>
> So this patch updates the places where we touch per cpu data
> to only touch online cpus, it makes cpu vector allocation
> an atomic operation with respect to cpu hotplug, and it updates
> the cpu start code to properly initialize vector_irq so we
> don't have inconsistencies.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>

Acked-by: Yinghai Lu <yinghai.lu@amd.com>

  reply	other threads:[~2006-10-23  6:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200610212100.k9LL0GtC018787@hera.kernel.org>
2006-10-22  3:51 ` [PATCH] x86-64: typo in __assign_irq_vector when updating pos for vector and offset Muli Ben-Yehuda
2006-10-22  5:13   ` Yinghai Lu
2006-10-22  6:55   ` yhlu
2006-10-22  8:50     ` Muli Ben-Yehuda
2006-10-22  8:50     ` Eric W. Biederman
2006-10-22  8:28   ` Yinghai Lu
2006-10-22  8:50     ` Muli Ben-Yehuda
2006-10-22  8:58       ` Eric W. Biederman
2006-10-22 16:02       ` yhlu
2006-10-22 16:19         ` yhlu
2006-10-22 21:33           ` Andi Kleen
2006-10-22 16:20         ` Muli Ben-Yehuda
2006-10-22 16:28           ` yhlu
2006-10-22  8:35   ` Eric W. Biederman
2006-10-22  8:52     ` Muli Ben-Yehuda
2006-10-22  9:10       ` Eric W. Biederman
2006-10-23  4:32       ` [PATCH 1/2] x86_64 irq: Simplify the vector allocator Eric W. Biederman
2006-10-23  4:35         ` [PATCH 2/2] x86_64 irq: Only look at per_cpu data for online cpus Eric W. Biederman
2006-10-23  6:17           ` yhlu [this message]
2006-10-23  8:14           ` Muli Ben-Yehuda
2006-10-23  6:15         ` [PATCH 1/2] x86_64 irq: Simplify the vector allocator yhlu
2006-10-24  5:29         ` Andi Kleen
2006-10-22 13:29   ` [PATCH] x86-64: typo in __assign_irq_vector when updating pos for vector and offset Andi Kleen
2006-10-22 16:31     ` Muli Ben-Yehuda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440610222317l1867ab38v4c33231b96237b7f@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muli@il.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®