mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [RFT 2.6] ebus.c replace pci_find_device with pci_get_device
@ 2004-10-08 22:53 Hanna Linder
  2004-10-09 17:21 ` Scott Feldman
  0 siblings, 1 reply; 4+ messages in thread
From: Hanna Linder @ 2004-10-08 22:53 UTC (permalink / raw)
  To: lkml, kernel-janitors; +Cc: greg, hannal, davem, ecd, jj, anton

As pci_find_device is going away I've replaced it with pci_get_device.
If someone with a Sparc64 system could test it I would appreciate it.
Thanks.

Hanna Linder
IBM Linux Technology Center

Signed-off-by: Hanna Linder <hannal@us.ibm.com>
---
diff -Nrup linux-2.6.9-rc3-mm3cln/arch/sparc64/kernel/ebus.c linux-2.6.9-rc3-mm3patch2/arch/sparc64/kernel/ebus.c
--- linux-2.6.9-rc3-mm3cln/arch/sparc64/kernel/ebus.c	2004-09-29 20:04:25.000000000 -0700
+++ linux-2.6.9-rc3-mm3patch2/arch/sparc64/kernel/ebus.c	2004-10-08 15:37:52.333561336 -0700
@@ -528,7 +528,7 @@ static struct pci_dev *find_next_ebus(st
 	struct pci_dev *pdev = start;
 
 	do {
-		pdev = pci_find_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev);
+		pdev = pci_get_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev);
 		if (pdev &&
 		    (pdev->device == PCI_DEVICE_ID_SUN_EBUS ||
 		     pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS))



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFT 2.6] ebus.c replace pci_find_device with pci_get_device
  2004-10-08 22:53 [RFT 2.6] ebus.c replace pci_find_device with pci_get_device Hanna Linder
@ 2004-10-09 17:21 ` Scott Feldman
  2004-10-12 16:43   ` Hanna Linder
  0 siblings, 1 reply; 4+ messages in thread
From: Scott Feldman @ 2004-10-09 17:21 UTC (permalink / raw)
  To: Hanna Linder; +Cc: lkml, kernel-janitors, greg, davem, ecd, jj, anton

On Fri, 2004-10-08 at 15:53, Hanna Linder wrote:
> @@ -528,7 +528,7 @@ static struct pci_dev *find_next_ebus(st
>  	struct pci_dev *pdev = start;
>  
>  	do {
> -		pdev = pci_find_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev);
> +		pdev = pci_get_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev);
>  		if (pdev &&
>  		    (pdev->device == PCI_DEVICE_ID_SUN_EBUS ||
>  		     pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS))

ebus_init() needs pci_put_dev(pdev) cleanup.

-scott


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFT 2.6] ebus.c replace pci_find_device with pci_get_device
  2004-10-09 17:21 ` Scott Feldman
@ 2004-10-12 16:43   ` Hanna Linder
  0 siblings, 0 replies; 4+ messages in thread
From: Hanna Linder @ 2004-10-12 16:43 UTC (permalink / raw)
  To: sfeldma; +Cc: Hanna Linder, lkml, kernel-janitors, greg, davem, ecd, jj, anton

--On Saturday, October 09, 2004 10:21:15 AM -0700 Scott Feldman <sfeldma@pobox.com> wrote:

> On Fri, 2004-10-08 at 15:53, Hanna Linder wrote:
>> @@ -528,7 +528,7 @@ static struct pci_dev *find_next_ebus(st
>>  	struct pci_dev *pdev = start;
>>  
>>  	do {
>> -		pdev = pci_find_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev);
>> +		pdev = pci_get_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev);
>>  		if (pdev &&
>>  		    (pdev->device == PCI_DEVICE_ID_SUN_EBUS ||
>>  		     pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS))
> 
> ebus_init() needs pci_put_dev(pdev) cleanup.
> 
> -scott
> 
> 

This is in a while loop with the pdev in the from* position. The dereference is
done automattically.

Thanks.

Hanna


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RFT 2.6] ebus.c replace pci_find_device with pci_get_device
@ 2004-10-08 22:26 Hanna Linder
  0 siblings, 0 replies; 4+ messages in thread
From: Hanna Linder @ 2004-10-08 22:26 UTC (permalink / raw)
  To: lkml, kernel-janitors; +Cc: greg, hannal, wli

As pci_find_device is going away I've replaced it with pci_get_device.
If someone with a Sparc system could test it I would appreciate it.
Thanks.

Hanna Linder
IBM Linux Technology Center

Signed-off-by: Hanna Linder <hannal@us.ibm.com>

---
diff -Nrup linux-2.6.9-rc3-mm3cln/arch/sparc/kernel/ebus.c linux-2.6.9-rc3-mm3patch2/arch/sparc/kernel/ebus.c
--- linux-2.6.9-rc3-mm3cln/arch/sparc/kernel/ebus.c	2004-09-29 20:05:51.000000000 -0700
+++ linux-2.6.9-rc3-mm3patch2/arch/sparc/kernel/ebus.c	2004-10-08 15:17:41.481638808 -0700
@@ -275,7 +275,7 @@ void __init ebus_init(void)
 		}
 	}
 
-	pdev = pci_find_device(PCI_VENDOR_ID_SUN, PCI_DEVICE_ID_SUN_EBUS, 0);
+	pdev = pci_get_device(PCI_VENDOR_ID_SUN, PCI_DEVICE_ID_SUN_EBUS, 0);
 	if (!pdev) {
 		return;
 	}
@@ -342,7 +342,7 @@ void __init ebus_init(void)
 		}
 
 	next_ebus:
-		pdev = pci_find_device(PCI_VENDOR_ID_SUN,
+		pdev = pci_get_device(PCI_VENDOR_ID_SUN,
 				       PCI_DEVICE_ID_SUN_EBUS, pdev);
 		if (!pdev)
 			break;


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2004-10-12 16:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-08 22:53 [RFT 2.6] ebus.c replace pci_find_device with pci_get_device Hanna Linder
2004-10-09 17:21 ` Scott Feldman
2004-10-12 16:43   ` Hanna Linder
  -- strict thread matches above, loose matches on Subject: below --
2004-10-08 22:26 Hanna Linder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®