mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	lustre-devel@lists.lustre.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] Assorted cleanups for staging/.../lustre/ldlm/ldlm_flock.c
Date: Thu, 26 Oct 2017 08:55:06 +1100	[thread overview]
Message-ID: <874lqmevut.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <alpine.LFD.2.20.1710242320020.20646@casper.infradead.org>

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

On Tue, Oct 24 2017, James Simmons wrote:

>> This file contains quite a bit of dead code and unused variables.
>> This patch series cleans it up in various ways.
>> It should change behaviour at all, just code
>> readability/maintainabilty.
>> 
>> I sent the back in July but got not response, possibly because there
>> were included with other patches which caused a distraction.
>> So here they are by themselves.
>
> Thanks for separating them out. I will give them a spin.
>

Thanks.  I have a growing series of cleanups (43 at present, including
these and the namei/dcache patches).  Is posting them here the best
approach?  I assume I should keep them in well-defined groups.  Should I
wait for one set to be merged before sending more, or should I just send
them when I think they are ready and you (or others) will look at them
as time permits.

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2017-10-25 21:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23  0:53 NeilBrown
2017-10-23  0:53 ` [PATCH 4/9] staging: lustre: ldlm: remove 'flags' arg from ldlm_process_flock_lock() NeilBrown
2017-10-27  9:19   ` Dilger, Andreas
2017-10-23  0:53 ` [PATCH 1/9] staging: lustre: ldlm: remove 'first_enq' " NeilBrown
2017-10-27  9:08   ` Dilger, Andreas
2017-10-23  0:53 ` [PATCH 2/9] staging: lustre: ldlm: remove unused 'work_list' " NeilBrown
2017-10-27  9:09   ` Dilger, Andreas
2017-10-23  0:53 ` [PATCH 8/9] staging: lustre: ldlm: remove unnecessary 'ownlocks' variable NeilBrown
2017-10-27  9:33   ` Dilger, Andreas
2017-10-23  0:53 ` [PATCH 7/9] staging: lustre: ldlm: tidy list walking in ldlm_flock() NeilBrown
2017-10-27  9:32   ` Dilger, Andreas
2017-10-23  0:53 ` [PATCH 9/9] staging: lustre: ldlm: remove unused field 'fwd_generation' NeilBrown
2017-10-27  9:39   ` [lustre-devel] " Dilger, Andreas
2017-10-27 11:10     ` NeilBrown
2017-10-23  0:53 ` [PATCH 3/9] staging: lustre: ldlm: remove unneeded 'err' arg to ldlm_process_flock_lock() NeilBrown
2017-10-27  9:11   ` Dilger, Andreas
2017-10-23  0:53 ` [PATCH 5/9] staging: lustre: ldlm: remove unused 'overlaps' variable NeilBrown
2017-10-27  9:20   ` Dilger, Andreas
2017-10-23  0:53 ` [PATCH 6/9] staging: lustre: ldlm: remove 'flags' arg from ldlm_flock_destroy() NeilBrown
2017-10-27  9:23   ` Dilger, Andreas
2017-10-24 22:20 ` [PATCH 0/9] Assorted cleanups for staging/.../lustre/ldlm/ldlm_flock.c James Simmons
2017-10-25 21:55   ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lqmevut.fsf@notabene.neil.brown.name \
    --to=neilb@suse.com \
    --cc=andreas.dilger@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®