From: Javier Martinez Canillas <javierm@redhat.com>
To: Maxime Ripard <mripard@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ssd130x: Drop _helper prefix from struct drm_*_helper_funcs callbacks
Date: Thu, 21 Sep 2023 10:25:17 +0200 [thread overview]
Message-ID: <875y44kk5u.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <2p53aei56tlr7k6w5oawlwpmv2k7agpbb6wfwpxcg3rqyueyrx@2as7tijrgnh4>
Maxime Ripard <mripard@kernel.org> writes:
> On Thu, Sep 21, 2023 at 09:57:22AM +0200, Geert Uytterhoeven wrote:
[...]
>> Anything else confuses the casual reader. Perhaps the real question is whether
>> the structures should have "helper" in their name in the first place?
>
> Those structures are meant for functions used by the helpers, they are not
> helper functions.
>
Ah, that makes more sense. I wasn't aware of that.
If that's the case, then the split makes more sense to me now.
> Maxime
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-09-21 18:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 19:51 Javier Martinez Canillas
2023-09-18 6:51 ` Thomas Zimmermann
2023-09-18 7:19 ` Javier Martinez Canillas
2023-09-21 7:44 ` Maxime Ripard
2023-09-21 7:57 ` Geert Uytterhoeven
2023-09-21 8:12 ` Maxime Ripard
2023-09-21 8:25 ` Javier Martinez Canillas [this message]
2023-09-21 8:46 ` Geert Uytterhoeven
2023-09-21 8:51 ` Maxime Ripard
2023-09-21 9:07 ` Geert Uytterhoeven
2023-09-21 8:55 ` Thomas Zimmermann
2023-09-21 8:23 ` Javier Martinez Canillas
2023-09-21 8:44 ` Thomas Zimmermann
2023-09-21 8:52 ` Thomas Zimmermann
2023-09-21 13:22 ` Maxime Ripard
2023-09-21 14:19 ` Maxime Ripard
2023-09-22 9:50 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y44kk5u.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®