From: Thomas Zimmermann <tzimmermann@suse.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Maxime Ripard <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org,
Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/ssd130x: Drop _helper prefix from struct drm_*_helper_funcs callbacks
Date: Thu, 21 Sep 2023 10:55:04 +0200 [thread overview]
Message-ID: <bee087f0-878c-480a-b72b-6b3dd69b84a6@suse.de> (raw)
In-Reply-To: <CAMuHMdV9Q=F6D=FgBYazjxGL8HY1cRLJUxdfdvr8=6fwgn+EHQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 927 bytes --]
Hi
Am 21.09.23 um 10:46 schrieb Geert Uytterhoeven:
[...]
>
>>> Anything else confuses the casual reader. Perhaps the real question is whether
>>> the structures should have "helper" in their name in the first place?
>>
>> Those structures are meant for functions used by the helpers, they are not
>> helper functions.
>
> That might be how they started, but to me it looks like all these helpers
> are no longer helpers, but part of the core...
They are in library modules. You can write a DRM driver without
_helper_funcs, see i915. It's just a really hard sell to upstream nowadays.
Best regards
Thomas
>
> Gr{oetje,eeting}s,
>
> Geert
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2023-09-21 17:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 19:51 Javier Martinez Canillas
2023-09-18 6:51 ` Thomas Zimmermann
2023-09-18 7:19 ` Javier Martinez Canillas
2023-09-21 7:44 ` Maxime Ripard
2023-09-21 7:57 ` Geert Uytterhoeven
2023-09-21 8:12 ` Maxime Ripard
2023-09-21 8:25 ` Javier Martinez Canillas
2023-09-21 8:46 ` Geert Uytterhoeven
2023-09-21 8:51 ` Maxime Ripard
2023-09-21 9:07 ` Geert Uytterhoeven
2023-09-21 8:55 ` Thomas Zimmermann [this message]
2023-09-21 8:23 ` Javier Martinez Canillas
2023-09-21 8:44 ` Thomas Zimmermann
2023-09-21 8:52 ` Thomas Zimmermann
2023-09-21 13:22 ` Maxime Ripard
2023-09-21 14:19 ` Maxime Ripard
2023-09-22 9:50 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bee087f0-878c-480a-b72b-6b3dd69b84a6@suse.de \
--to=tzimmermann@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®