* [PATCH 1/2] ALSA: usb-audio: Add quirk for Fiero SC-01 @ 2022-06-27 10:00 Egor Vorontsov 2022-06-27 10:00 ` [PATCH 2/2] ALSA: usb-audio: Add quirk for Fiero SC-01 (fw v1.0.0) Egor Vorontsov 2022-07-04 12:12 ` [PATCH 1/2] ALSA: usb-audio: Add quirk for Fiero SC-01 Takashi Iwai 0 siblings, 2 replies; 3+ messages in thread From: Egor Vorontsov @ 2022-06-27 10:00 UTC (permalink / raw) Cc: Egor Vorontsov, Jaroslav Kysela, Takashi Iwai, Jonas Hahnfeld, William Overton, Brendan Grieve, Alexander Tsoy, moderated list:SOUND, open list Fiero SC-01 is a USB sound card with two mono inputs and a single stereo output. The inputs are composed into a single stereo stream. The device uses a vendor-provided driver on Windows and does not work at all without it. The driver mostly provides ASIO functionality, but also alters the way the sound card is queried for sample rates and clocks. ALSA queries those failing with an EPIPE (same as Windows 10 does). Presumably, the vendor-provided driver does not query it at all, simply matching by VID:PID. Thus, I consider this a buggy firmware and adhere to a set of fixed endpoint quirks instead. The soundcard has an internal clock. Implicit feedback mode is required for the playback. I have updated my device to v1.1.0 from a Windows 10 VM using a vendor- provided binary prior to the development, hoping for it to just begin working. The device provides no obvious way to downgrade the firmware, and regardless, there's no binary available for v1.0.0 anyway. Thus, I will be getting another unit to extend the patch with support for that. Expected to be a simple copy-paste of the existing one, though. There were no previous reports of that device in context of Linux anywhere. Other issues have been reported though, but that's out of the scope. Signed-off-by: Egor Vorontsov <sdoregor@sdore.me> --- sound/usb/quirks-table.h | 68 ++++++++++++++++++++++++++++++++++++++++ sound/usb/quirks.c | 2 ++ 2 files changed, 70 insertions(+) diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index 4f56e1784932..c61445eb83d8 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -4119,6 +4119,74 @@ YAMAHA_DEVICE(0x7010, "UB99"), } } }, +{ + /* + * Fiero SC-01 (firmware v1.1.0) + */ + USB_DEVICE(0x2b53, 0x0031), + .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { + .vendor_name = "Fiero", + .product_name = "SC-01", + .ifnum = QUIRK_ANY_INTERFACE, + .type = QUIRK_COMPOSITE, + .data = &(const struct snd_usb_audio_quirk[]) { + { + .ifnum = 0, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + /* Playback */ + { + .ifnum = 1, + .type = QUIRK_AUDIO_FIXED_ENDPOINT, + .data = &(const struct audioformat) { + .formats = SNDRV_PCM_FMTBIT_S32_LE, + .channels = 2, + .fmt_bits = 24, + .iface = 1, + .altsetting = 1, + .altset_idx = 1, + .endpoint = 0x01, + .ep_attr = USB_ENDPOINT_XFER_ISOC | + USB_ENDPOINT_SYNC_ASYNC, + .rates = SNDRV_PCM_RATE_48000 | + SNDRV_PCM_RATE_96000, + .rate_min = 48000, + .rate_max = 96000, + .nr_rates = 2, + .rate_table = (unsigned int[]) { 48000, 96000 }, + .clock = 0x29 + } + }, + /* Capture */ + { + .ifnum = 2, + .type = QUIRK_AUDIO_FIXED_ENDPOINT, + .data = &(const struct audioformat) { + .formats = SNDRV_PCM_FMTBIT_S32_LE, + .channels = 2, + .fmt_bits = 24, + .iface = 2, + .altsetting = 1, + .altset_idx = 1, + .endpoint = 0x82, + .ep_attr = USB_ENDPOINT_XFER_ISOC | + USB_ENDPOINT_SYNC_ASYNC | + USB_ENDPOINT_USAGE_IMPLICIT_FB, + .rates = SNDRV_PCM_RATE_48000 | + SNDRV_PCM_RATE_96000, + .rate_min = 48000, + .rate_max = 96000, + .nr_rates = 2, + .rate_table = (unsigned int[]) { 48000, 96000 }, + .clock = 0x29 + } + }, + { + .ifnum = -1 + } + } + } +}, #undef USB_DEVICE_VENDOR_SPEC #undef USB_AUDIO_DEVICE diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index e8468f9b007d..81bdd921a279 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1908,6 +1908,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = { QUIRK_FLAG_ALIGN_TRANSFER), DEVICE_FLG(0x1224, 0x2a25, /* Jieli Technology USB PHY 2.0 */ QUIRK_FLAG_GET_SAMPLE_RATE), + DEVICE_FLG(0x2b53, 0x0031, /* Fiero SC-01 (firmware v1.1.0) */ + QUIRK_FLAG_GENERIC_IMPLICIT_FB), /* Vendor matches */ VENDOR_FLG(0x045e, /* MS Lifecam */ -- 2.36.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] ALSA: usb-audio: Add quirk for Fiero SC-01 (fw v1.0.0) 2022-06-27 10:00 [PATCH 1/2] ALSA: usb-audio: Add quirk for Fiero SC-01 Egor Vorontsov @ 2022-06-27 10:00 ` Egor Vorontsov 2022-07-04 12:12 ` [PATCH 1/2] ALSA: usb-audio: Add quirk for Fiero SC-01 Takashi Iwai 1 sibling, 0 replies; 3+ messages in thread From: Egor Vorontsov @ 2022-06-27 10:00 UTC (permalink / raw) Cc: Egor Vorontsov, Jaroslav Kysela, Takashi Iwai, Jonas Hahnfeld, Brendan Grieve, William Overton, Alexander Tsoy, moderated list:SOUND, open list The patch applies the same quirks used for SC-01 at firmware v1.1.0 to the ones running v1.0.0, with respect to hard-coded sample rates. I got two more units and successfully tested the patch series with both firmwares. The support is now complete (not accounting ASIO). Signed-off-by: Egor Vorontsov <sdoregor@sdore.me> --- sound/usb/quirks-table.h | 132 +++++++++++++++++++++++++++++++++++++++ sound/usb/quirks.c | 4 ++ 2 files changed, 136 insertions(+) diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index c61445eb83d8..fdd62139d1ab 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -4119,6 +4119,138 @@ YAMAHA_DEVICE(0x7010, "UB99"), } } }, +{ + /* + * Fiero SC-01 (firmware v1.0.0 @ 48 kHz) + */ + USB_DEVICE(0x2b53, 0x0023), + .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { + .vendor_name = "Fiero", + .product_name = "SC-01", + .ifnum = QUIRK_ANY_INTERFACE, + .type = QUIRK_COMPOSITE, + .data = &(const struct snd_usb_audio_quirk[]) { + { + .ifnum = 0, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + /* Playback */ + { + .ifnum = 1, + .type = QUIRK_AUDIO_FIXED_ENDPOINT, + .data = &(const struct audioformat) { + .formats = SNDRV_PCM_FMTBIT_S32_LE, + .channels = 2, + .fmt_bits = 24, + .iface = 1, + .altsetting = 1, + .altset_idx = 1, + .endpoint = 0x01, + .ep_attr = USB_ENDPOINT_XFER_ISOC | + USB_ENDPOINT_SYNC_ASYNC, + .rates = SNDRV_PCM_RATE_48000, + .rate_min = 48000, + .rate_max = 48000, + .nr_rates = 1, + .rate_table = (unsigned int[]) { 48000 }, + .clock = 0x29 + } + }, + /* Capture */ + { + .ifnum = 2, + .type = QUIRK_AUDIO_FIXED_ENDPOINT, + .data = &(const struct audioformat) { + .formats = SNDRV_PCM_FMTBIT_S32_LE, + .channels = 2, + .fmt_bits = 24, + .iface = 2, + .altsetting = 1, + .altset_idx = 1, + .endpoint = 0x82, + .ep_attr = USB_ENDPOINT_XFER_ISOC | + USB_ENDPOINT_SYNC_ASYNC | + USB_ENDPOINT_USAGE_IMPLICIT_FB, + .rates = SNDRV_PCM_RATE_48000, + .rate_min = 48000, + .rate_max = 48000, + .nr_rates = 1, + .rate_table = (unsigned int[]) { 48000 }, + .clock = 0x29 + } + }, + { + .ifnum = -1 + } + } + } +}, +{ + /* + * Fiero SC-01 (firmware v1.0.0 @ 96 kHz) + */ + USB_DEVICE(0x2b53, 0x0024), + .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { + .vendor_name = "Fiero", + .product_name = "SC-01", + .ifnum = QUIRK_ANY_INTERFACE, + .type = QUIRK_COMPOSITE, + .data = &(const struct snd_usb_audio_quirk[]) { + { + .ifnum = 0, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + /* Playback */ + { + .ifnum = 1, + .type = QUIRK_AUDIO_FIXED_ENDPOINT, + .data = &(const struct audioformat) { + .formats = SNDRV_PCM_FMTBIT_S32_LE, + .channels = 2, + .fmt_bits = 24, + .iface = 1, + .altsetting = 1, + .altset_idx = 1, + .endpoint = 0x01, + .ep_attr = USB_ENDPOINT_XFER_ISOC | + USB_ENDPOINT_SYNC_ASYNC, + .rates = SNDRV_PCM_RATE_96000, + .rate_min = 96000, + .rate_max = 96000, + .nr_rates = 1, + .rate_table = (unsigned int[]) { 96000 }, + .clock = 0x29 + } + }, + /* Capture */ + { + .ifnum = 2, + .type = QUIRK_AUDIO_FIXED_ENDPOINT, + .data = &(const struct audioformat) { + .formats = SNDRV_PCM_FMTBIT_S32_LE, + .channels = 2, + .fmt_bits = 24, + .iface = 2, + .altsetting = 1, + .altset_idx = 1, + .endpoint = 0x82, + .ep_attr = USB_ENDPOINT_XFER_ISOC | + USB_ENDPOINT_SYNC_ASYNC | + USB_ENDPOINT_USAGE_IMPLICIT_FB, + .rates = SNDRV_PCM_RATE_96000, + .rate_min = 96000, + .rate_max = 96000, + .nr_rates = 1, + .rate_table = (unsigned int[]) { 96000 }, + .clock = 0x29 + } + }, + { + .ifnum = -1 + } + } + } +}, { /* * Fiero SC-01 (firmware v1.1.0) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 81bdd921a279..5ff22cc3d7c1 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1908,6 +1908,10 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = { QUIRK_FLAG_ALIGN_TRANSFER), DEVICE_FLG(0x1224, 0x2a25, /* Jieli Technology USB PHY 2.0 */ QUIRK_FLAG_GET_SAMPLE_RATE), + DEVICE_FLG(0x2b53, 0x0023, /* Fiero SC-01 (firmware v1.0.0 @ 48 kHz) */ + QUIRK_FLAG_GENERIC_IMPLICIT_FB), + DEVICE_FLG(0x2b53, 0x0024, /* Fiero SC-01 (firmware v1.0.0 @ 96 kHz) */ + QUIRK_FLAG_GENERIC_IMPLICIT_FB), DEVICE_FLG(0x2b53, 0x0031, /* Fiero SC-01 (firmware v1.1.0) */ QUIRK_FLAG_GENERIC_IMPLICIT_FB), -- 2.36.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ALSA: usb-audio: Add quirk for Fiero SC-01 2022-06-27 10:00 [PATCH 1/2] ALSA: usb-audio: Add quirk for Fiero SC-01 Egor Vorontsov 2022-06-27 10:00 ` [PATCH 2/2] ALSA: usb-audio: Add quirk for Fiero SC-01 (fw v1.0.0) Egor Vorontsov @ 2022-07-04 12:12 ` Takashi Iwai 1 sibling, 0 replies; 3+ messages in thread From: Takashi Iwai @ 2022-07-04 12:12 UTC (permalink / raw) To: Egor Vorontsov Cc: Jaroslav Kysela, Takashi Iwai, Jonas Hahnfeld, William Overton, Brendan Grieve, Alexander Tsoy, moderated list:SOUND, open list On Mon, 27 Jun 2022 12:00:34 +0200, Egor Vorontsov wrote: > > Fiero SC-01 is a USB sound card with two mono inputs and a single > stereo output. The inputs are composed into a single stereo stream. > > The device uses a vendor-provided driver on Windows and does not work > at all without it. The driver mostly provides ASIO functionality, but > also alters the way the sound card is queried for sample rates and > clocks. > > ALSA queries those failing with an EPIPE (same as Windows 10 does). > Presumably, the vendor-provided driver does not query it at all, simply > matching by VID:PID. Thus, I consider this a buggy firmware and adhere > to a set of fixed endpoint quirks instead. > > The soundcard has an internal clock. Implicit feedback mode is required > for the playback. > > I have updated my device to v1.1.0 from a Windows 10 VM using a vendor- > provided binary prior to the development, hoping for it to just begin > working. The device provides no obvious way to downgrade the firmware, > and regardless, there's no binary available for v1.0.0 anyway. > > Thus, I will be getting another unit to extend the patch with support > for that. Expected to be a simple copy-paste of the existing one, > though. > > There were no previous reports of that device in context of Linux > anywhere. Other issues have been reported though, but that's out of the > scope. > > Signed-off-by: Egor Vorontsov <sdoregor@sdore.me> Thanks, now applied both patches. Takashi ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-04 12:12 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-06-27 10:00 [PATCH 1/2] ALSA: usb-audio: Add quirk for Fiero SC-01 Egor Vorontsov 2022-06-27 10:00 ` [PATCH 2/2] ALSA: usb-audio: Add quirk for Fiero SC-01 (fw v1.0.0) Egor Vorontsov 2022-07-04 12:12 ` [PATCH 1/2] ALSA: usb-audio: Add quirk for Fiero SC-01 Takashi Iwai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®