* [PATCH] PCI / PM: Add dev_dbg() to print device suspend power states
@ 2017-09-29 23:31 Rafael J. Wysocki
2017-10-02 23:29 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2017-09-29 23:31 UTC (permalink / raw)
To: Bjorn Helgaas, Linux PCI; +Cc: Linux PM, LKML, Srinivas Pandruvada
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
It sometimes is useful to know what power states the kernel thinks
it puts PCI devices into during system suspend, so add a dev_dbg()
statement for that.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/pci/pci-driver.c | 3 +++
1 file changed, 3 insertions(+)
Index: linux-pm/drivers/pci/pci-driver.c
===================================================================
--- linux-pm.orig/drivers/pci/pci-driver.c
+++ linux-pm/drivers/pci/pci-driver.c
@@ -798,6 +798,9 @@ static int pci_pm_suspend_noirq(struct d
pci_prepare_to_sleep(pci_dev);
}
+ dev_dbg(dev, "PCI PM: Suspend power state: %s\n",
+ pci_power_name(pci_dev->current_state));
+
pci_pm_set_unknown_state(pci_dev);
/*
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI / PM: Add dev_dbg() to print device suspend power states
2017-09-29 23:31 [PATCH] PCI / PM: Add dev_dbg() to print device suspend power states Rafael J. Wysocki
@ 2017-10-02 23:29 ` Bjorn Helgaas
2017-10-02 23:45 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2017-10-02 23:29 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Bjorn Helgaas, Linux PCI, Linux PM, LKML, Srinivas Pandruvada
On Sat, Sep 30, 2017 at 01:31:15AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> It sometimes is useful to know what power states the kernel thinks
> it puts PCI devices into during system suspend, so add a dev_dbg()
> statement for that.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
I think you have other pending changes in this path, so can you take
this one as well?
> ---
> drivers/pci/pci-driver.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: linux-pm/drivers/pci/pci-driver.c
> ===================================================================
> --- linux-pm.orig/drivers/pci/pci-driver.c
> +++ linux-pm/drivers/pci/pci-driver.c
> @@ -798,6 +798,9 @@ static int pci_pm_suspend_noirq(struct d
> pci_prepare_to_sleep(pci_dev);
> }
>
> + dev_dbg(dev, "PCI PM: Suspend power state: %s\n",
> + pci_power_name(pci_dev->current_state));
> +
> pci_pm_set_unknown_state(pci_dev);
>
> /*
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI / PM: Add dev_dbg() to print device suspend power states
2017-10-02 23:29 ` Bjorn Helgaas
@ 2017-10-02 23:45 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2017-10-02 23:45 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Rafael J. Wysocki, Bjorn Helgaas, Linux PCI, Linux PM, LKML,
Srinivas Pandruvada
On Tue, Oct 3, 2017 at 1:29 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Sat, Sep 30, 2017 at 01:31:15AM +0200, Rafael J. Wysocki wrote:
>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>
>> It sometimes is useful to know what power states the kernel thinks
>> it puts PCI devices into during system suspend, so add a dev_dbg()
>> statement for that.
>>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> I think you have other pending changes in this path, so can you take
> this one as well?
Yes, I can, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-02 23:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-29 23:31 [PATCH] PCI / PM: Add dev_dbg() to print device suspend power states Rafael J. Wysocki
2017-10-02 23:29 ` Bjorn Helgaas
2017-10-02 23:45 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®