mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Punit Agrawal <punit.agrawal@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Guenter Roeck <linux@roeck-us.net>,
	Jean Delvare <jdelvare@suse.com>,
	lm-sensors@lm-sensors.org
Subject: Re: [PATCH 1/2] firmware: arm_scpi: add support for 64-bit sensor values
Date: Mon, 15 Feb 2016 18:36:04 +0000	[thread overview]
Message-ID: <87a8n1akiz.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <1455028377-12728-1-git-send-email-sudeep.holla@arm.com> (Sudeep Holla's message of "Tue, 9 Feb 2016 14:32:56 +0000")

Sudeep Holla <sudeep.holla@arm.com> writes:

> SCPI specification version 1.1 extended the sensor from 32-bit to 64-bit
> values in order to accommodate new sensor class with 64-bit requirements
>
> Since the SCPI driver sets the higher 32-bit for older protocol version
> to zeros, there's no need to explicitly check the SCPI protocol version
> and the backward compatibility is maintainted.
>
> Cc: Punit Agrawal <punit.agrawal@arm.com>

Thanks for the update to the driver.

       Reviewed-by: Punit Agrawal <punit.agrawal@arm.com>

> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/firmware/arm_scpi.c   | 8 +++++---
>  drivers/hwmon/scpi-hwmon.c    | 6 +++---
>  include/linux/scpi_protocol.h | 2 +-
>  3 files changed, 9 insertions(+), 7 deletions(-)
>
> Hi Guenter,
>
> Since I have couple of other fixes for SCPI driver, if you can provide
> your ACKs to this couple of patches after your review, I can take all of
> them together via ARM-SoC if that's fine with you.
>
> Regards,
> Sudeep
>

[...]

  parent reply	other threads:[~2016-02-15 18:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 14:32 Sudeep Holla
2016-02-09 14:32 ` [PATCH 2/2] hwmon: (scpi) add energy meter support Sudeep Holla
2016-02-15 18:38   ` Punit Agrawal
2016-02-16  1:41   ` Guenter Roeck
2016-02-15 18:36 ` Punit Agrawal [this message]
2016-02-16  1:40 ` [PATCH 1/2] firmware: arm_scpi: add support for 64-bit sensor values Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8n1akiz.fsf@e105922-lin.cambridge.arm.com \
    --to=punit.agrawal@arm.com \
    --cc=jdelvare@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®