From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Jann Horn <jannh@google.com>
Cc: Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Denys Vlasenko <vda.linux@googlemail.com>,
Kees Cook <keescook@chromium.org>,
Vlastimil Babka <vbabka@suse.cz>,
"Liam R . Howlett" <liam.howlett@oracle.com>
Subject: [PATCH 0/5] Fix fill_files_note
Date: Mon, 31 Jan 2022 12:44:53 -0600 [thread overview]
Message-ID: <87bkzroica.fsf_-_@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <CAG48ez3MCs8d8hjBfRSQxwUTW3o64iaSwxF=UEVtk+SEme0chQ@mail.gmail.com> (Jann Horn's message of "Mon, 31 Jan 2022 18:13:42 +0100")
Matthew Wilcox has reported that a missing mmap_lock in file_files_note,
which could cause trouble.
Refactor the code and clean it up so that the vma snapshot makes
it to fill_files_note, and then use the vma snapshot in fill_files_note.
Folks please review this as this looks correct to me but I haven't done
anything beyond compile testing this yet.
Eric W. Biederman (5):
coredump: Move definition of struct coredump_params into coredump.h
coredump: Snapshot the vmas in do_coredump
coredump: Remove the WARN_ON in dump_vma_snapshot
coredump/elf: Pass coredump_params into fill_note_info
coredump: Use the vma snapshot in fill_files_note
fs/binfmt_elf.c | 61 ++++++++++++++++++++++--------------------------
fs/binfmt_elf_fdpic.c | 18 +++++---------
fs/coredump.c | 55 +++++++++++++++++++++++++++++--------------
include/linux/binfmts.h | 13 +----------
include/linux/coredump.h | 20 ++++++++++++----
5 files changed, 88 insertions(+), 79 deletions(-)
Eric
next prev parent reply other threads:[~2022-01-31 18:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 15:37 [PATCH] binfmt_elf: Take the mmap lock when walking the VMA list Matthew Wilcox (Oracle)
2022-01-31 16:03 ` Eric W. Biederman
2022-01-31 16:13 ` Matthew Wilcox
2022-01-31 16:26 ` Eric W. Biederman
2022-01-31 16:35 ` Matthew Wilcox
2022-01-31 17:13 ` Jann Horn
2022-01-31 18:44 ` Eric W. Biederman [this message]
2022-01-31 18:46 ` [PATCH 1/5] coredump: Move definition of struct coredump_params into coredump.h Eric W. Biederman
2022-02-01 1:54 ` kernel test robot
2022-02-01 4:07 ` kernel test robot
2022-01-31 18:46 ` [PATCH 2/5] coredump: Snapshot the vmas in do_coredump Eric W. Biederman
2022-02-01 18:32 ` Jann Horn
2022-02-02 15:41 ` Eric W. Biederman
2022-01-31 18:46 ` [PATCH 3/5] coredump: Remove the WARN_ON in dump_vma_snapshot Eric W. Biederman
2022-02-01 18:35 ` Jann Horn
2022-01-31 18:47 ` [PATCH 4/5] coredump/elf: Pass coredump_params into fill_note_info Eric W. Biederman
2022-02-01 18:40 ` Jann Horn
2022-01-31 18:47 ` [PATCH 5/5] coredump: Use the vma snapshot in fill_files_note Eric W. Biederman
2022-02-01 19:02 ` Jann Horn
2022-02-02 14:46 ` Eric W. Biederman
2022-01-31 20:57 ` [PATCH 0/5] Fix fill_files_note Kees Cook
2022-03-08 19:35 ` [GIT PULL] " Eric W. Biederman
2022-03-08 21:49 ` Kees Cook
2022-03-09 16:29 ` Eric W. Biederman
2022-03-09 16:32 ` Kees Cook
2022-03-09 20:27 ` Eric W. Biederman
2022-03-09 21:45 ` Kees Cook
2022-01-31 17:38 ` [PATCH] binfmt_elf: Take the mmap lock when walking the VMA list Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkzroica.fsf_-_@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=liam.howlett@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=vda.linux@googlemail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®