mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Jann Horn <jannh@google.com>
Cc: Matthew Wilcox <willy@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Denys Vlasenko <vda.linux@googlemail.com>,
	Kees Cook <keescook@chromium.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	"Liam R . Howlett" <liam.howlett@oracle.com>
Subject: [PATCH 3/5] coredump: Remove the WARN_ON in dump_vma_snapshot
Date: Mon, 31 Jan 2022 12:46:44 -0600	[thread overview]
Message-ID: <87tudjn3or.fsf_-_@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <87bkzroica.fsf_-_@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Mon, 31 Jan 2022 12:44:53 -0600")


The condition is impossible and to the best of my knowledge has never
triggered.

We are in deep trouble if that conditions happens and we walk past
the end of our allocated array.

So delete the WARN_ON and the code that makes it look like the kernel
can handle the case of walking past the end of it's vma_meta array.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
 fs/coredump.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/fs/coredump.c b/fs/coredump.c
index def2a0c9cb14..c5e7d63525c6 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -1127,10 +1127,5 @@ static bool dump_vma_snapshot(struct coredump_params *cprm)
 
 	mmap_write_unlock(mm);
 
-	if (WARN_ON(i != cprm->vma_count)) {
-		kvfree(cprm->vma_meta);
-		return false;
-	}
-
 	return true;
 }
-- 
2.29.2


  parent reply	other threads:[~2022-01-31 18:47 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 15:37 [PATCH] binfmt_elf: Take the mmap lock when walking the VMA list Matthew Wilcox (Oracle)
2022-01-31 16:03 ` Eric W. Biederman
2022-01-31 16:13   ` Matthew Wilcox
2022-01-31 16:26     ` Eric W. Biederman
2022-01-31 16:35       ` Matthew Wilcox
2022-01-31 17:13         ` Jann Horn
2022-01-31 18:44           ` [PATCH 0/5] Fix fill_files_note Eric W. Biederman
2022-01-31 18:46             ` [PATCH 1/5] coredump: Move definition of struct coredump_params into coredump.h Eric W. Biederman
2022-02-01  1:54               ` kernel test robot
2022-02-01  4:07               ` kernel test robot
2022-01-31 18:46             ` [PATCH 2/5] coredump: Snapshot the vmas in do_coredump Eric W. Biederman
2022-02-01 18:32               ` Jann Horn
2022-02-02 15:41                 ` Eric W. Biederman
2022-01-31 18:46             ` Eric W. Biederman [this message]
2022-02-01 18:35               ` [PATCH 3/5] coredump: Remove the WARN_ON in dump_vma_snapshot Jann Horn
2022-01-31 18:47             ` [PATCH 4/5] coredump/elf: Pass coredump_params into fill_note_info Eric W. Biederman
2022-02-01 18:40               ` Jann Horn
2022-01-31 18:47             ` [PATCH 5/5] coredump: Use the vma snapshot in fill_files_note Eric W. Biederman
2022-02-01 19:02               ` Jann Horn
2022-02-02 14:46                 ` Eric W. Biederman
2022-01-31 20:57             ` [PATCH 0/5] Fix fill_files_note Kees Cook
2022-03-08 19:35             ` [GIT PULL] " Eric W. Biederman
2022-03-08 21:49               ` Kees Cook
2022-03-09 16:29                 ` Eric W. Biederman
2022-03-09 16:32                   ` Kees Cook
2022-03-09 20:27                     ` Eric W. Biederman
2022-03-09 21:45                       ` Kees Cook
2022-01-31 17:38         ` [PATCH] binfmt_elf: Take the mmap lock when walking the VMA list Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tudjn3or.fsf_-_@email.froward.int.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=jannh@google.com \
    --cc=keescook@chromium.org \
    --cc=liam.howlett@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vbabka@suse.cz \
    --cc=vda.linux@googlemail.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®