From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Johan Hovold <johan@kernel.org>,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
lgirdwood@gmail.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] ASoC: qcom: common: add Display port Jack function
Date: Fri, 31 May 2024 07:44:41 +0100 [thread overview]
Message-ID: <87e109a7-2088-42f7-b8c1-fb549fe3e377@linaro.org> (raw)
In-Reply-To: <Zlj_4IuZqnC3gESL@eriador.lumag.spb.ru>
On 30/05/2024 23:38, Dmitry Baryshkov wrote:
>>> It will always be DP out of the machine even if an adapter can convert
>>> to HDMI internally.
>>>
>>> The DRM ports are called "DP-1" and "DP-2" so it seems we should match
>>> that.
>>>
>>>> This is the most common naming for the USB-C DP/HDMI jack events.
>>> It looks like some Intel machines use names like "HDMI/DP, pcm=%d Jack"
>>> (with a pcm device number), but we also have "DP Jack". Not sure which
>>> are are used with USB-C, though. (Or if the former actually support HDMI
>>> altmode.)
>> I checked this on my machine which has usb-c and I can confirm using HDMI/DP
>> naming for these jack.
>>
>> Either way I don't mind having any names, but my point here is to be more
>> consistent across.
> I fear it is till not consistent. On the Intel laptop I see following
> jacks:
>
> numid=18,iface=CARD,name='HDMI/DP,pcm=3 Jack'
> numid=24,iface=CARD,name='HDMI/DP,pcm=7 Jack'
> numid=30,iface=CARD,name='HDMI/DP,pcm=8 Jack'
>
> On the other hand Mediatek and RockChip use just 'DP Jack'.
>
> I'd suggest settling on the latter option. We are closer to MTK and
> RockChip rather than Intel.
that is fine with me.
>
> BTW: a platform can easily have 4 (x1e8100) or even 8 (sc8280xp) DP
> outputs. Could you please point out why there are just 3 jacks?
The CRD platform that I have access to has 3 ports which is why I
started with 3 ports, but we can add more ports as and when we can
really test them.
--srini
next prev parent reply other threads:[~2024-05-31 6:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 13:43 [PATCH v2 0/4] ASoC: qcom: display port changes srinivas.kandagatla
2024-04-22 13:43 ` [PATCH v2 1/4] ASoC: qcom: q6dsp: parse Display port tokens srinivas.kandagatla
2024-04-22 13:43 ` [PATCH v2 2/4] ASoC: qcom: common: add Display port Jack function srinivas.kandagatla
2024-04-23 11:44 ` Johan Hovold
2024-04-23 12:02 ` Johan Hovold
2024-04-23 15:55 ` Srinivas Kandagatla
2024-04-29 14:54 ` Johan Hovold
2024-05-09 8:59 ` Srinivas Kandagatla
2024-05-30 22:38 ` Dmitry Baryshkov
2024-05-31 6:44 ` Srinivas Kandagatla [this message]
2024-04-22 13:43 ` [PATCH v2 3/4] ASoC: qcom: sc8280xp: add Display port Jack srinivas.kandagatla
2024-04-23 11:48 ` Johan Hovold
2024-05-30 22:41 ` Dmitry Baryshkov
2024-04-22 13:43 ` [PATCH v2 4/4] ASoC: qcom: sm8250: fix a typo in function name srinivas.kandagatla
2024-04-23 11:59 ` [PATCH v2 0/4] ASoC: qcom: display port changes Johan Hovold
2024-04-23 12:38 ` Srinivas Kandagatla
2024-04-23 14:58 ` Johan Hovold
2024-04-23 15:59 ` Srinivas Kandagatla
2024-04-29 15:00 ` Johan Hovold
2024-05-30 22:56 ` Dmitry Baryshkov
2024-05-23 4:09 ` Xilin Wu
2024-05-24 12:50 ` Srinivas Kandagatla
2024-05-25 7:12 ` Xilin Wu
2024-06-06 9:18 ` Srinivas Kandagatla
2024-06-08 11:41 ` Xilin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87e109a7-2088-42f7-b8c1-fb549fe3e377@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®