mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: srinivas.kandagatla@linaro.org
Cc: broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
	lgirdwood@gmail.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org,
	Bjorn Andersson <quic_bjorande@quicinc.com>
Subject: Re: [PATCH v2 0/4] ASoC: qcom: display port changes
Date: Tue, 23 Apr 2024 13:59:01 +0200	[thread overview]
Message-ID: <ZieihZRKe7OtP-nV@hovoldconsulting.com> (raw)
In-Reply-To: <20240422134354.89291-1-srinivas.kandagatla@linaro.org>

On Mon, Apr 22, 2024 at 02:43:50PM +0100, Srinivas Kandagatla wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> This patchset adds support for.
> 	1. parse Display Port module tokens from ASoC topology
> 	2. add support to DP/HDMI Jack events.
> 	3. fixes a typo in function name in sm8250
> 
> Verified these patches on X13s along with changes to tplg in 
> https://git.codelinaro.org/linaro/qcomlt/audioreach-topology/-/tree/topic/x13s-dp?ref_type=heads
> and ucm changes from https://github.com/Srinivas-Kandagatla/alsa-ucm-conf/tree/topic/x13s-dp

It looks like your UCM changes are still muxing the speaker and *each*
displayport output so that you can only use one device at a time (i.e.
only Speaker or DP1 or DP2 can be used).

As we discussed off list last week, this seems unnecessarily limited and
as far as I understood is mostly needed to work around some
implementation details (not sure why DP1 and DP2 can't be used in
parallel either).

Can you please describe the problem here so that we can discuss this
before merging an unnecessarily restricted solution which may later be
harder to change (e.g. as kernel, topology and ucm may again need to be
updated in lock step).

From what I could tell after a quick look, this series does not
necessarily depend on muxing things this way, but please confirm that
too.

Johan

  parent reply	other threads:[~2024-04-23 11:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 13:43 srinivas.kandagatla
2024-04-22 13:43 ` [PATCH v2 1/4] ASoC: qcom: q6dsp: parse Display port tokens srinivas.kandagatla
2024-04-22 13:43 ` [PATCH v2 2/4] ASoC: qcom: common: add Display port Jack function srinivas.kandagatla
2024-04-23 11:44   ` Johan Hovold
2024-04-23 12:02   ` Johan Hovold
2024-04-23 15:55     ` Srinivas Kandagatla
2024-04-29 14:54       ` Johan Hovold
2024-05-09  8:59         ` Srinivas Kandagatla
2024-05-30 22:38           ` Dmitry Baryshkov
2024-05-31  6:44             ` Srinivas Kandagatla
2024-04-22 13:43 ` [PATCH v2 3/4] ASoC: qcom: sc8280xp: add Display port Jack srinivas.kandagatla
2024-04-23 11:48   ` Johan Hovold
2024-05-30 22:41   ` Dmitry Baryshkov
2024-04-22 13:43 ` [PATCH v2 4/4] ASoC: qcom: sm8250: fix a typo in function name srinivas.kandagatla
2024-04-23 11:59 ` Johan Hovold [this message]
2024-04-23 12:38   ` [PATCH v2 0/4] ASoC: qcom: display port changes Srinivas Kandagatla
2024-04-23 14:58     ` Johan Hovold
2024-04-23 15:59       ` Srinivas Kandagatla
2024-04-29 15:00         ` Johan Hovold
2024-05-30 22:56     ` Dmitry Baryshkov
2024-05-23  4:09 ` Xilin Wu
2024-05-24 12:50   ` Srinivas Kandagatla
2024-05-25  7:12     ` Xilin Wu
2024-06-06  9:18       ` Srinivas Kandagatla
2024-06-08 11:41         ` Xilin Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZieihZRKe7OtP-nV@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=quic_bjorande@quicinc.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®