From: "Huang, Ying" <ying.huang@intel.com>
To: Alejandro Lucero Palau <alucerop@amd.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Gregory Price <gourry@gourry.net>,
"Davidlohr Bueso" <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Ben Cheatham <benjamin.cheatham@amd.com>
Subject: Re: [PATCH 5/5] cxl: Avoid to create dax regions for type2 accelerators
Date: Thu, 17 Oct 2024 15:48:04 +0800 [thread overview]
Message-ID: <87frov6uh7.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <ea8afddb-9e97-98f6-b1ee-b5394d35e8c0@amd.com> (Alejandro Lucero Palau's message of "Thu, 17 Oct 2024 08:27:01 +0100")
Alejandro Lucero Palau <alucerop@amd.com> writes:
> On 10/17/24 07:29, Huang, Ying wrote:
>> Hi, Alejandro,
>>
>> Alejandro Lucero Palau <alucerop@amd.com> writes:
>>
>>> I did comment on this some time ago and I'm doing it again.
>>>
>>>
>>> This is originally part of the type2 patchset, and I'm keeping it in
>>> V4. I do not understand why you pick code changes (you explicitly said
>>> that in the first RFC) from there and use it here, and without
>>> previous discussion about this necessity in the list. I do not think
>>> this is usual, at least in other kernel subsystems I'm more familiar
>>> with, so I will raise this in today's cxl open source collaboration
>>> sync.
>> No. I picked this change from Dan's series as follows,
>>
>> https://eclists.intel.com/sympa//arc/linux-bkc/2024-10/msg00018.html
>>
>> So, I added co-developed-by and signed-off-by of Dan.
>>
>> IIUC, your picked this change from Dan's series too?
>
>
> Look, this is not going well.
>
>
> You specifically said in your first patchset you considered the type2
> support patchset complete but too large or complex, so you were taking
> parts of it as a prelude for making it easier to review/accept. Just
> face that and not twist the argument.
Although I listed your patchset in my cover letter. All changes I
picked was from Dan's patchset instead of yours. And, I kept Dan's
co-developed-by and signed-off-by. If you will pick changes from Dan,
please do that too.
> FWIW, I'm against you doing so because:
>
>
> 1) You should have commented in the type2 patchset about your concern,
> and gave advice about doing such a prelude (by me) or offer yourself
> for doing it.
>
> 2) Just following your approach, anyone could do the same for any
> patchset sent to the list. This is not a good precedent.
>
> 3) If this is going to be allowed/approved, I'm not going to be
> comfortable within this community. If it is just me, I guess it will
> not be a big loss.
>
>
> None has commented yet except you and me, what I do not know if it is
> because this is a nasty discussion they do not want to get entangle
> with, or because they just think your approach is OK. If not further
> comment and your patchset is accepted, nothing else will be needed to
> say.
>
>
>> Feel free to include this change in your series. If your patchset is
>> merged firstly, I will rebase on yours and drop this change.
>>
>> [snip]
--
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2024-10-17 7:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 6:57 [PATCH 0/5] cxl: Some preparation work for type2 accelerators support Huang Ying
2024-10-15 6:57 ` [PATCH 1/5] cxl: Rename ACPI_CEDT_CFMWS_RESTRICT_TYPE2/TYPE3 Huang Ying
2024-10-15 6:57 ` [PATCH 2/5] cxl: Rename CXL_DECODER_HOSTONLYMEM/DEVMEM Huang Ying
2024-10-17 22:21 ` Dan Williams
2024-10-18 6:18 ` Huang, Ying
2024-10-18 21:17 ` Dan Williams
2024-10-21 4:40 ` Huang, Ying
2024-10-15 6:57 ` [PATCH 3/5] cxl: Separate coherence from target type Huang Ying
2024-10-17 22:25 ` Dan Williams
2024-10-15 6:57 ` [PATCH 4/5] cxl: Set type of region to that of the first endpoint Huang Ying
2024-10-17 22:33 ` Dan Williams
2024-10-18 6:50 ` Huang, Ying
2024-10-18 21:19 ` Dan Williams
2024-10-21 6:33 ` Huang, Ying
2024-10-21 9:47 ` Alejandro Lucero Palau
2024-10-15 6:57 ` [PATCH 5/5] cxl: Avoid to create dax regions for type2 accelerators Huang Ying
2024-10-15 8:51 ` Alejandro Lucero Palau
2024-10-17 6:29 ` Huang, Ying
2024-10-17 7:27 ` Alejandro Lucero Palau
2024-10-17 7:48 ` Huang, Ying [this message]
2024-10-18 9:57 ` Jonathan Cameron
2024-10-21 11:37 ` Huang, Ying
2024-10-17 23:15 ` Dan Williams
2024-10-21 11:52 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frov6uh7.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=alison.schofield@intel.com \
--cc=alucerop@amd.com \
--cc=benjamin.cheatham@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=gourry@gourry.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®