From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fat: remove unused parameter
Date: Tue, 02 Dec 2025 07:45:18 +0900 [thread overview]
Message-ID: <87h5u9vn29.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20251201214403.90604-2-lalitshankarch@gmail.com>
Lalit Shankar Chowdhury <lalitshankarch@gmail.com> writes:
> Remove unused inode parameter from fat_cache_alloc().
>
> Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
Looks good.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
> fs/fat/cache.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c
> index 2af424e200b3..4cea26ddc161 100644
> --- a/fs/fat/cache.c
> +++ b/fs/fat/cache.c
> @@ -59,7 +59,7 @@ void fat_cache_destroy(void)
> kmem_cache_destroy(fat_cache_cachep);
> }
>
> -static inline struct fat_cache *fat_cache_alloc(struct inode *inode)
> +static inline struct fat_cache *fat_cache_alloc(void)
> {
> return kmem_cache_alloc(fat_cache_cachep, GFP_NOFS);
> }
> @@ -149,7 +149,7 @@ static void fat_cache_add(struct inode *inode, struct fat_cache_id *new)
> MSDOS_I(inode)->nr_caches++;
> spin_unlock(&MSDOS_I(inode)->cache_lru_lock);
>
> - tmp = fat_cache_alloc(inode);
> + tmp = fat_cache_alloc();
> if (!tmp) {
> spin_lock(&MSDOS_I(inode)->cache_lru_lock);
> MSDOS_I(inode)->nr_caches--;
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2025-12-01 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 21:44 Lalit Shankar Chowdhury
2025-12-01 22:45 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5u9vn29.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=lalitshankarch@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®