* [PATCH] fat: remove unused parameter
@ 2025-12-01 21:44 Lalit Shankar Chowdhury
2025-12-01 22:45 ` OGAWA Hirofumi
0 siblings, 1 reply; 2+ messages in thread
From: Lalit Shankar Chowdhury @ 2025-12-01 21:44 UTC (permalink / raw)
To: hirofumi; +Cc: linux-kernel, Lalit Shankar Chowdhury
Remove unused inode parameter from fat_cache_alloc().
Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
---
fs/fat/cache.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/fat/cache.c b/fs/fat/cache.c
index 2af424e200b3..4cea26ddc161 100644
--- a/fs/fat/cache.c
+++ b/fs/fat/cache.c
@@ -59,7 +59,7 @@ void fat_cache_destroy(void)
kmem_cache_destroy(fat_cache_cachep);
}
-static inline struct fat_cache *fat_cache_alloc(struct inode *inode)
+static inline struct fat_cache *fat_cache_alloc(void)
{
return kmem_cache_alloc(fat_cache_cachep, GFP_NOFS);
}
@@ -149,7 +149,7 @@ static void fat_cache_add(struct inode *inode, struct fat_cache_id *new)
MSDOS_I(inode)->nr_caches++;
spin_unlock(&MSDOS_I(inode)->cache_lru_lock);
- tmp = fat_cache_alloc(inode);
+ tmp = fat_cache_alloc();
if (!tmp) {
spin_lock(&MSDOS_I(inode)->cache_lru_lock);
MSDOS_I(inode)->nr_caches--;
--
2.52.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fat: remove unused parameter
2025-12-01 21:44 [PATCH] fat: remove unused parameter Lalit Shankar Chowdhury
@ 2025-12-01 22:45 ` OGAWA Hirofumi
0 siblings, 0 replies; 2+ messages in thread
From: OGAWA Hirofumi @ 2025-12-01 22:45 UTC (permalink / raw)
To: Lalit Shankar Chowdhury; +Cc: linux-kernel, Andrew Morton
Lalit Shankar Chowdhury <lalitshankarch@gmail.com> writes:
> Remove unused inode parameter from fat_cache_alloc().
>
> Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
Looks good.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
> fs/fat/cache.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c
> index 2af424e200b3..4cea26ddc161 100644
> --- a/fs/fat/cache.c
> +++ b/fs/fat/cache.c
> @@ -59,7 +59,7 @@ void fat_cache_destroy(void)
> kmem_cache_destroy(fat_cache_cachep);
> }
>
> -static inline struct fat_cache *fat_cache_alloc(struct inode *inode)
> +static inline struct fat_cache *fat_cache_alloc(void)
> {
> return kmem_cache_alloc(fat_cache_cachep, GFP_NOFS);
> }
> @@ -149,7 +149,7 @@ static void fat_cache_add(struct inode *inode, struct fat_cache_id *new)
> MSDOS_I(inode)->nr_caches++;
> spin_unlock(&MSDOS_I(inode)->cache_lru_lock);
>
> - tmp = fat_cache_alloc(inode);
> + tmp = fat_cache_alloc();
> if (!tmp) {
> spin_lock(&MSDOS_I(inode)->cache_lru_lock);
> MSDOS_I(inode)->nr_caches--;
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-01 22:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-01 21:44 [PATCH] fat: remove unused parameter Lalit Shankar Chowdhury
2025-12-01 22:45 ` OGAWA Hirofumi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®