From: Thomas Gleixner <tglx@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Hyunwoo Kim <imv4bel@gmail.com>,
brauner@kernel.org, peterz@infradead.org,
anna-maria@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] signal: Use list_del_init_careful() in flush_sigqueue()
Date: Mon, 31 Aug 2026 11:53:58 +0200 [thread overview]
Message-ID: <87pkyyd39l.ffs@fw13> (raw)
In-Reply-To: <87zey3fep2.fsf@email.froward.int.ebiederm.org>
On Sun, Aug 30 2026 at 17:04, Eric W. Biederman wrote:
> Thomas Gleixner <tglx@kernel.org> writes:
>> Something like the below?
>
> Yes.
>
> It all comes after
> ptrace_event(PTRACE_EVENT_EXIT, code) and
> coredump_task_exit(tsk, core_state)
> so should be completely invisible to userspace.
>
> I don't see any problems with your proposed patch.
Let me write a change log then.
> I am pondering what it would take to move
> "flush_sigqueue(&p->signal->shared_pending);"
> into do_exit in the group_dead case.
>
> Perhaps exit_signals could perform the decrement of signal->live
> and return group_dead. If so all of the work could be performed
> in exit_signals(). As a follow-on change of cource.
I thought about that too, but that was looked too scary to me :)
next prev parent reply other threads:[~2026-08-31 9:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 5:37 Hyunwoo Kim
2026-08-22 10:27 ` Bradley Morgan
2026-08-23 12:47 ` Oleg Nesterov
2026-08-24 2:53 ` Hyunwoo Kim
2026-08-24 8:28 ` Oleg Nesterov
2026-08-24 8:04 ` Thomas Gleixner
2026-08-24 9:45 ` Thomas Gleixner
2026-08-24 11:02 ` Oleg Nesterov
2026-08-24 11:54 ` Oleg Nesterov
2026-08-24 13:59 ` Frederic Weisbecker
2026-08-24 14:29 ` Oleg Nesterov
2026-08-25 16:58 ` Thomas Gleixner
2026-08-25 18:53 ` Oleg Nesterov
2026-08-25 19:58 ` Thomas Gleixner
2026-08-26 9:36 ` Oleg Nesterov
2026-08-26 19:19 ` Thomas Gleixner
2026-08-26 19:32 ` Oleg Nesterov
2026-08-27 3:29 ` Eric W. Biederman
2026-08-27 9:35 ` Thomas Gleixner
2026-08-27 18:43 ` Eric W. Biederman
2026-08-27 22:56 ` Thomas Gleixner
2026-08-30 18:19 ` Thomas Gleixner
2026-08-30 22:04 ` Eric W. Biederman
2026-08-31 9:53 ` Thomas Gleixner [this message]
2026-08-31 10:50 ` [PATCH] signal: Prevent exec() race Thomas Gleixner
2026-08-31 11:35 ` David Laight
2026-08-31 12:44 ` Oleg Nesterov
2026-09-01 12:49 ` Thomas Gleixner
2026-08-31 12:52 ` Frederic Weisbecker
2026-09-01 12:55 ` Thomas Gleixner
2026-09-01 13:27 ` Frederic Weisbecker
2026-09-01 15:14 ` Thomas Gleixner
2026-08-31 15:26 ` Eric W. Biederman
2026-09-01 13:35 ` Thomas Gleixner
2026-09-01 17:21 ` Eric W. Biederman
2026-09-01 18:40 ` [PATCH V2] " Thomas Gleixner
2026-09-02 10:28 ` Oleg Nesterov
2026-09-02 10:45 ` Oleg Nesterov
2026-09-03 6:09 ` Thomas Gleixner
2026-09-02 11:23 ` Oleg Nesterov
2026-09-02 14:19 ` Oleg Nesterov
2026-09-02 15:39 ` Eric W. Biederman
2026-09-02 17:08 ` Oleg Nesterov
2026-09-03 6:42 ` Thomas Gleixner
2026-09-03 7:29 ` Oleg Nesterov
2026-08-27 12:24 ` [PATCH] signal: Use list_del_init_careful() in flush_sigqueue() Thomas Gleixner
2026-08-27 17:51 ` Thomas Gleixner
2026-08-24 12:11 ` Thomas Gleixner
2026-08-24 16:31 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pkyyd39l.ffs@fw13 \
--to=tglx@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=frederic@kernel.org \
--cc=imv4bel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®