* [PATCHv3] ALSA: hda/realtek: Add quirk for ASUS ROG G533Q
@ 2023-09-21 7:22 Abelardo Ricart
2023-09-21 7:33 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Abelardo Ricart @ 2023-09-21 7:22 UTC (permalink / raw)
To: linux-kernel; +Cc: perex, tiwai, alsa-devel
The same quirk applied to the ASUS G533Z is also applicable to the ASUS
G533Q (of which I am an owner and have thus tested).
Signed-off-by: Abelardo Ricart <aricart@gmail.com>
---
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index dc7b7a407638..fdc3560ad951 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9649,6 +9649,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", ALC285_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", ALC285_FIXUP_ASUS_HEADSET_MIC),
+ SND_PCI_QUIRK(0x1043, 0x1602, "ASUS ROG Strix G15 (G533Q)", ALC285_FIXUP_ASUS_G533Z_PINS),
SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCHv3] ALSA: hda/realtek: Add quirk for ASUS ROG G533Q
2023-09-21 7:22 [PATCHv3] ALSA: hda/realtek: Add quirk for ASUS ROG G533Q Abelardo Ricart
@ 2023-09-21 7:33 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2023-09-21 7:33 UTC (permalink / raw)
To: Abelardo Ricart; +Cc: linux-kernel, perex, tiwai, alsa-devel
On Thu, 21 Sep 2023 09:22:57 +0200,
Abelardo Ricart wrote:
>
> The same quirk applied to the ASUS G533Z is also applicable to the ASUS
> G533Q (of which I am an owner and have thus tested).
>
> Signed-off-by: Abelardo Ricart <aricart@gmail.com>
Unfortunately it's still a problem; tabs are converted to 4 spaces.
I recommend you to try sending to yourself locally and verify whether
it works before resubmitting v4.
thanks,
Takashi
> ---
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index dc7b7a407638..fdc3560ad951 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9649,6 +9649,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", ALC285_FIXUP_ASUS_HEADSET_MIC),
> SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
> SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", ALC285_FIXUP_ASUS_HEADSET_MIC),
> + SND_PCI_QUIRK(0x1043, 0x1602, "ASUS ROG Strix G15 (G533Q)", ALC285_FIXUP_ASUS_G533Z_PINS),
> SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
> SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2),
> SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-21 20:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-21 7:22 [PATCHv3] ALSA: hda/realtek: Add quirk for ASUS ROG G533Q Abelardo Ricart
2023-09-21 7:33 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®