From: John Ogness <john.ogness@linutronix.de>
To: David Engraf <david.engraf@sysgo.com>,
tony.lindgren@linux.intel.com, pmladek@suse.com,
rostedt@goodmis.org, senozhatsky@chromium.org
Cc: linux-kernel@vger.kernel.org, David Engraf <david.engraf@sysgo.com>
Subject: Re: [PATCH v3] printk: Remove console options before decoding the name
Date: Tue, 29 Sep 2026 17:36:51 +0206 [thread overview]
Message-ID: <87wls4vzv8.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20260924070153.250783-2-david.engraf@sysgo.com>
On 2026-09-24, David Engraf <david.engraf@sysgo.com> wrote:
> This fixes a regression when a console option includes ':'. Commit
> 7640f1a44eba ("printk: Add match_devname_and_update_preferred_console()")
> introduced console=DEVNAME:0.0 hardware style addressing by looking for a
> colon. If the colon is part of an option the name is handled as devname
> instead of ttyname.
>
> Fix by handling the options first which will add a NULL terminator to the
> string and refactor idx handling to clean up the code (thanks to Petr
> Mladek).
>
> Signed-off-by: David Engraf <david.engraf@sysgo.com>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
prev parent reply other threads:[~2026-09-29 15:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 5:32 [PATCH] " David Engraf
2026-09-16 5:48 ` Tony Lindgren
2026-09-16 5:51 ` David Engraf
2026-09-17 6:05 ` [PATCH v2] " David Engraf
2026-09-17 14:03 ` Tony Lindgren
2026-09-18 6:27 ` David Engraf
2026-09-21 5:17 ` Tony Lindgren
2026-09-21 6:18 ` David Engraf
2026-09-23 9:37 ` Petr Mladek
2026-09-23 10:19 ` Tony Lindgren
2026-09-23 12:06 ` Petr Mladek
2026-09-23 12:14 ` Tony Lindgren
2026-09-23 13:56 ` David Engraf
2026-09-24 7:00 ` [PATCH v3] " David Engraf
2026-09-24 7:42 ` Tony Lindgren
2026-09-28 6:18 ` David Engraf
2026-09-29 13:48 ` Petr Mladek
2026-09-29 15:30 ` John Ogness [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wls4vzv8.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=david.engraf@sysgo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tony.lindgren@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®