mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: David Engraf <david.engraf@sysgo.com>
Cc: tony.lindgren@linux.intel.com, rostedt@goodmis.org,
	john.ogness@linutronix.de, senozhatsky@chromium.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] printk: Remove console options before decoding the name
Date: Tue, 29 Sep 2026 15:48:05 +0200	[thread overview]
Message-ID: <arvBlQog3bBULfQV@pathway.suse.cz> (raw)
In-Reply-To: <20260924070153.250783-2-david.engraf@sysgo.com>

On Thu 2026-09-24 10:00:57, David Engraf wrote:
> This fixes a regression when a console option includes ':'. Commit
> 7640f1a44eba ("printk: Add match_devname_and_update_preferred_console()")
> introduced console=DEVNAME:0.0 hardware style addressing by looking for a
> colon. If the colon is part of an option the name is handled as devname
> instead of ttyname.
> 
> Fix by handling the options first which will add a NULL terminator to the
> string and refactor idx handling to clean up the code (thanks to Petr
> Mladek).
> 
> Signed-off-by: David Engraf <david.engraf@sysgo.com>

Looks good to me:

Reviewed-by: Petr Mladek <pmladek@suse.com>

There is no need to send v4 just to update the commit message. I could
do so when committing the change.

I am going to wait one or two more days for more potential feedback.
Then I'll push it with the updated commit message unless anyone
complains in the meantime.

Best Regards,
Petr

  parent reply	other threads:[~2026-09-29 13:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  5:32 [PATCH] " David Engraf
2026-09-16  5:48 ` Tony Lindgren
2026-09-16  5:51   ` David Engraf
2026-09-17  6:05     ` [PATCH v2] " David Engraf
2026-09-17 14:03       ` Tony Lindgren
2026-09-18  6:27         ` David Engraf
2026-09-21  5:17           ` Tony Lindgren
2026-09-21  6:18             ` David Engraf
2026-09-23  9:37       ` Petr Mladek
2026-09-23 10:19         ` Tony Lindgren
2026-09-23 12:06           ` Petr Mladek
2026-09-23 12:14             ` Tony Lindgren
2026-09-23 13:56               ` David Engraf
2026-09-24  7:00                 ` [PATCH v3] " David Engraf
2026-09-24  7:42                   ` Tony Lindgren
2026-09-28  6:18                     ` David Engraf
2026-09-29 13:48                   ` Petr Mladek [this message]
2026-09-29 15:30                   ` John Ogness

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arvBlQog3bBULfQV@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=david.engraf@sysgo.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=tony.lindgren@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®