mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: mtd: arasan: Add ZynqMP props
@ 2026-09-22 18:31 Rob Herring (Arm)
  2026-09-25  9:16 ` Miquel Raynal
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring (Arm) @ 2026-09-22 18:31 UTC (permalink / raw)
  To: Miquel Raynal, Michal Simek, Richard Weinberger,
	Vignesh Raghavendra, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-mtd, devicetree, linux-kernel

ZynqMP NAND controller nodes contain "num-cs" and "power-domains"
properties. Add num-cs with a range of one to two chip selects and allow
one power-domain.

Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../devicetree/bindings/mtd/arasan,nand-controller.yaml   | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
index b90d3b48c2f2..4262996dd51e 100644
--- a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
+++ b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
@@ -35,6 +35,14 @@ properties:
   interrupts:
     maxItems: 1
 
+  num-cs:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 1
+    maximum: 2
+
+  power-domains:
+    maxItems: 1
+
 required:
   - compatible
   - reg
-- 
2.53.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: mtd: arasan: Add ZynqMP props
  2026-09-22 18:31 [PATCH] dt-bindings: mtd: arasan: Add ZynqMP props Rob Herring (Arm)
@ 2026-09-25  9:16 ` Miquel Raynal
  2026-09-25 12:20   ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Miquel Raynal @ 2026-09-25  9:16 UTC (permalink / raw)
  To: Rob Herring (Arm)
  Cc: Michal Simek, Richard Weinberger, Vignesh Raghavendra,
	Krzysztof Kozlowski, Conor Dooley, linux-mtd, devicetree,
	linux-kernel

Hi Rob,

> +  num-cs:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 1
> +    maximum: 2

I am not sure I get what is the purpose of this property. It looks like
a downstream property resurfacing. We expect one DT subnode per chip, so
I don't see the need for num-cs, we just need to count the children
nodes. For me, the correct fix is to drop num-cs from the upstream DT.
The only real use for it would be if the hardware could be synthesized
differently, with a single CS instead of 2, but I don't think it's the
case here.

> +
> +  power-domains:
> +    maxItems: 1

This one, even though we don't actively use it in Linux, it may serve a
real purpose.

Thanks,
Miquèl

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: mtd: arasan: Add ZynqMP props
  2026-09-25  9:16 ` Miquel Raynal
@ 2026-09-25 12:20   ` Rob Herring
  2026-09-25 12:52     ` Miquel Raynal
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2026-09-25 12:20 UTC (permalink / raw)
  To: Miquel Raynal
  Cc: Michal Simek, Richard Weinberger, Vignesh Raghavendra,
	Krzysztof Kozlowski, Conor Dooley, linux-mtd, devicetree,
	linux-kernel

On Fri, Sep 25, 2026 at 11:16:21AM +0200, Miquel Raynal wrote:
> Hi Rob,
> 
> > +  num-cs:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    minimum: 1
> > +    maximum: 2
> 
> I am not sure I get what is the purpose of this property. It looks like
> a downstream property resurfacing. We expect one DT subnode per chip, so
> I don't see the need for num-cs, we just need to count the children
> nodes. For me, the correct fix is to drop num-cs from the upstream DT.
> The only real use for it would be if the hardware could be synthesized
> differently, with a single CS instead of 2, but I don't think it's the
> case here.

Indeed.

> > +
> > +  power-domains:
> > +    maxItems: 1
> 
> This one, even though we don't actively use it in Linux, it may serve a
> real purpose.

The driver core takes care of 'power-domains', so how is it not used?

Rob


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: mtd: arasan: Add ZynqMP props
  2026-09-25 12:20   ` Rob Herring
@ 2026-09-25 12:52     ` Miquel Raynal
  2026-09-25 12:58       ` Michal Simek
  0 siblings, 1 reply; 5+ messages in thread
From: Miquel Raynal @ 2026-09-25 12:52 UTC (permalink / raw)
  To: Rob Herring
  Cc: Michal Simek, Richard Weinberger, Vignesh Raghavendra,
	Krzysztof Kozlowski, Conor Dooley, linux-mtd, devicetree,
	linux-kernel

On 25/09/2026 at 07:20:03 -05, Rob Herring <robh@kernel.org> wrote:

> On Fri, Sep 25, 2026 at 11:16:21AM +0200, Miquel Raynal wrote:
>> Hi Rob,
>> 
>> > +  num-cs:
>> > +    $ref: /schemas/types.yaml#/definitions/uint32
>> > +    minimum: 1
>> > +    maximum: 2
>> 
>> I am not sure I get what is the purpose of this property. It looks like
>> a downstream property resurfacing. We expect one DT subnode per chip, so
>> I don't see the need for num-cs, we just need to count the children
>> nodes. For me, the correct fix is to drop num-cs from the upstream DT.
>> The only real use for it would be if the hardware could be synthesized
>> differently, with a single CS instead of 2, but I don't think it's the
>> case here.
>
> Indeed.
>
>> > +
>> > +  power-domains:
>> > +    maxItems: 1
>> 
>> This one, even though we don't actively use it in Linux, it may serve a
>> real purpose.
>
> The driver core takes care of 'power-domains', so how is it not used?

Yes, it is probably useful. I am pretty sure I did not use that property
when I tested the driver, but the controller was either already set up
by the Bootloader or in a domain enabled by another device. In both
cases, it is worth adding.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: mtd: arasan: Add ZynqMP props
  2026-09-25 12:52     ` Miquel Raynal
@ 2026-09-25 12:58       ` Michal Simek
  0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2026-09-25 12:58 UTC (permalink / raw)
  To: Miquel Raynal, Rob Herring
  Cc: Richard Weinberger, Vignesh Raghavendra, Krzysztof Kozlowski,
	Conor Dooley, linux-mtd, devicetree, linux-kernel



On 9/25/26 14:52, Miquel Raynal wrote:
> On 25/09/2026 at 07:20:03 -05, Rob Herring <robh@kernel.org> wrote:
> 
>> On Fri, Sep 25, 2026 at 11:16:21AM +0200, Miquel Raynal wrote:
>>> Hi Rob,
>>>
>>>> +  num-cs:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    minimum: 1
>>>> +    maximum: 2
>>>
>>> I am not sure I get what is the purpose of this property. It looks like
>>> a downstream property resurfacing. We expect one DT subnode per chip, so
>>> I don't see the need for num-cs, we just need to count the children
>>> nodes. For me, the correct fix is to drop num-cs from the upstream DT.
>>> The only real use for it would be if the hardware could be synthesized
>>> differently, with a single CS instead of 2, but I don't think it's the
>>> case here.
>>
>> Indeed.
>>
>>>> +
>>>> +  power-domains:
>>>> +    maxItems: 1
>>>
>>> This one, even though we don't actively use it in Linux, it may serve a
>>> real purpose.
>>
>> The driver core takes care of 'power-domains', so how is it not used?
> 
> Yes, it is probably useful. I am pretty sure I did not use that property
> when I tested the driver, but the controller was either already set up
> by the Bootloader or in a domain enabled by another device. In both
> cases, it is worth adding.

It shouldn't be a problem to list it. We have never used it but obviously there 
is power domain.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-09-25 12:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-22 18:31 [PATCH] dt-bindings: mtd: arasan: Add ZynqMP props Rob Herring (Arm)
2026-09-25  9:16 ` Miquel Raynal
2026-09-25 12:20   ` Rob Herring
2026-09-25 12:52     ` Miquel Raynal
2026-09-25 12:58       ` Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®